[native] stop persisting reports
ClosedPublic
Actions

Authored by kamil on May 23 2023, 4:00 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM4dc5bc99ef9e: [native] stop persisting reports

Summary

queuedReports are now stored in SQLite, but still we want to save enabledReports.

Depends on D7938

Test Plan

Check is persisting works for enabledReports and queuedReports are not persisted.

Also, with this diff I tested entire stack end-to-end.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kamil held this revision as a draft.

kamil published this revision for review.May 23 2023, 4:56 PM

native/redux/persist.js
617–625 ↗	(On Diff #26861)	Would this be easier to achieve by handling `rehydrateActionType` in the reducer? Or is there some benefit from doing it via a transform?

This revision is now accepted and ready to land.May 24 2023, 3:20 AM

rebase before landing

native/redux/persist.js
617–625 ↗	(On Diff #26861)	Would this be easier to achieve by handling `rehydrateActionType` in the reducer? I don't think so, `rehydrateActionType` is not enough, we will also need to do something on `persist/PERSIST` action. Or is there some benefit from doing it via a transform? We need to remove reports before persisting, and add an empty array on rehydration - that's why this transform has two callbacks (inbound and outbound). I think the benefit is that we use the proper tools for our usage - using actions `persist/PERSIST` and `persist/REHYDRATE` is less readable for me.