queuedReports are now stored in SQLite, but still we want to save enabledReports.
Depends on D7938
Details
Details
- Reviewers
tomek michal - Commits
- rCOMM4dc5bc99ef9e: [native] stop persisting reports
Check is persisting works for enabledReports and queuedReports are not persisted.
Also, with this diff I tested entire stack end-to-end.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/redux/persist.js | ||
|---|---|---|
| 617–625 ↗ | (On Diff #26861) | Would this be easier to achieve by handling rehydrateActionType in the reducer? Or is there some benefit from doing it via a transform? |
Comment Actions
rebase before landing
| native/redux/persist.js | ||
|---|---|---|
| 617–625 ↗ | (On Diff #26861) |
I don't think so, rehydrateActionType is not enough, we will also need to do something on persist/PERSIST action.
We need to remove reports before persisting, and add an empty array on rehydration - that's why this transform has two callbacks (inbound and outbound). I think the benefit is that we use the proper tools for our usage - using actions persist/PERSIST and persist/REHYDRATE is less readable for me. |