Paths

Table of Contentst

[web-db] implement SQL queries for report store
ClosedPublic
Actions

Authored by kamil on May 25 2023, 10:28 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMc34f13c3fa14: [web-db] implement SQL queries for report store

Summary

Mapping native structure and logic

Depends on D7982

Test Plan

Run tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 25 2023, 10:28 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 25 2023, 10:28 AM

kamil added a child revision: D7984: [web-db] add report table on web.May 25 2023, 10:29 AM

Harbormaster completed remote builds in B19776: Diff 27068.May 25 2023, 10:46 AM

kamil published this revision for review.May 25 2023, 1:46 PM

michal accepted this revision.May 30 2023, 8:26 AM

michal added inline comments.

web/database/queries/report-queries.test.js
25 ↗	(On Diff #27068)	Shouldn't we `setupSQLiteDB` in the `beforeAll`?
76 ↗	(On Diff #27068)	I think you missed the name

This revision is now accepted and ready to land.May 30 2023, 8:26 AM

add missing name

web/database/queries/report-queries.test.js
25 ↗	(On Diff #27068)	because tests are concentrated on the `reports` table (created via `createReportTable()`) it doesn't really make any difference, I'll remove this
76 ↗	(On Diff #27068)	oversight, fixing

Harbormaster completed remote builds in B19929: Diff 27309.May 31 2023, 10:09 AM

Closed by commit rCOMMc34f13c3fa14: [web-db] implement SQL queries for report store (authored by kamil). · Explain WhyMay 31 2023, 10:12 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc34f13c3fa14: [web-db] implement SQL queries for report store.

Revision Contents
Changeset List

Path

Size

web/

database/

queries/

report-queries.js

72 lines

report-queries.test.js

86 lines

Diff 27311

View Options

web/database/queries/report-queries.js