Page MenuHomePhabricator
Differential D7937

[native] start processing report store operations on database
ClosedPublic
Actions

Authored by kamil on Tue, May 23, 3:28 AM.

Details

Reviewers
tomek
michal
Commits
rCOMM3294c18298d0: [native] start processing report store operations on database
Summary

Enable running ops on SQLite.

Depends on D7936, D7933

Test Plan

Create some ops in reducer and check if they're properly processed on SQLite

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, May 23, 3:28 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptTue, May 23, 3:28 AM
kamil added a child revision: D7938: [native] fetch reports from SQLite and dispatch to store.Tue, May 23, 3:44 AM
Harbormaster completed remote builds in B19649: Diff 26857.Tue, May 23, 3:46 AM
kamil published this revision for review.Tue, May 23, 4:55 PM
tomek accepted this revision.Wed, May 24, 3:11 AM
tomek added inline comments.
lib/ops/report-store-ops.js
90 ↗(On Diff #26857)

Should we e.g. throw when an unsupported operation appears?

This revision is now accepted and ready to land.Wed, May 24, 3:11 AM
kamil edited parent revisions, added: D7977: [native] migrate reports to SQLite; removed: D7936: [CommCoreModule] implement getting report store from database.Thu, May 25, 7:57 AM
kamil updated this revision to Diff 27297.Wed, May 31, 8:28 AM
kamil added a parent revision: D7936: [CommCoreModule] implement getting report store from database.

rebase before landing

lib/ops/report-store-ops.js
90 ↗(On Diff #26857)

In other cases we throw from C++ level, I'll follow current approach

kamil removed a parent revision: D7936: [CommCoreModule] implement getting report store from database.Wed, May 31, 8:29 AM
Harbormaster completed remote builds in B19922: Diff 27297.Wed, May 31, 8:48 AM
Closed by commit rCOMM3294c18298d0: [native] start processing report store operations on database (authored by kamil). · Explain WhyWed, May 31, 9:24 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3294c18298d0: [native] start processing report store operations on database.

Revision Contents
Changeset List

PathSize
native/
redux/
3 lines
13 lines

Diff 27304

View Options

native/redux/redux-setup.js

Loading...
View Options

native/redux/redux-utils.js

Loading...