Page MenuHomePhabricator

[native] start processing report store operations on database
ClosedPublic

Authored by kamil on Tue, May 23, 3:28 AM.

Details

Summary

Enable running ops on SQLite.

Depends on D7936, D7933

Test Plan

Create some ops in reducer and check if they're properly processed on SQLite

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Tue, May 23, 4:55 PM
tomek added inline comments.
lib/ops/report-store-ops.js
90 ↗(On Diff #26857)

Should we e.g. throw when an unsupported operation appears?

This revision is now accepted and ready to land.Wed, May 24, 3:11 AM

rebase before landing

lib/ops/report-store-ops.js
90 ↗(On Diff #26857)

In other cases we throw from C++ level, I'll follow current approach