[lib] add tests for report reducer
ClosedPublic
Actions

Authored by kamil on May 22 2023, 10:14 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMdf9755520d23: [lib] add tests for report reducer

Summary

After implementing operations architecture in this reducer we will not be using comparing operations vs old logic, that being said those tests should make sure that new logic will be correct

Depends on D7916

Test Plan

run tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 22 2023, 10:14 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 22 2023, 10:14 AM

kamil removed a reviewer: atul.May 22 2023, 10:31 AM

Harbormaster completed remote builds in B19608: Diff 26801.May 22 2023, 10:32 AM

kamil added a child revision: D7920: [lib] add report store ops on JS side.May 22 2023, 10:46 AM

kamil published this revision for review.May 23 2023, 1:46 AM

tomek accepted this revision.May 24 2023, 2:03 AM

This revision is now accepted and ready to land.May 24 2023, 2:03 AM

rebase

Harbormaster completed remote builds in B19811: Diff 27130.May 29 2023, 3:59 AM

Closed by commit rCOMMdf9755520d23: [lib] add tests for report reducer (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdf9755520d23: [lib] add tests for report reducer.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

report-store-reducer.test.js

287 lines

types/

report-types.js

2 lines

Diff 27138

View Options

lib/reducers/report-store-reducer.test.js

This file was added.

				// @flow

				import { processReportStoreOperations } from './report-store-ops.js';
				import {
				type ClientReportCreationRequest,
				reportTypes,
				} from '../types/report-types.js';

				const defaultReport = {
				type: reportTypes.MEDIA_MISSION,
				time: Date.now(),
				mediaMission: {
				steps: [],
				result: { success: true },
				totalTime: 0,
				userTime: 0,
				},
				};

				const defaultMockReportWeb = {
				platformDetails: { platform: 'web' },
				...defaultReport,
				};

				const defaultMockReportIos = {
				platformDetails: { platform: 'ios' },
				...defaultReport,
				};

				const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportWeb,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];

				const sortReports = (
				queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
				): $ReadOnlyArray<ClientReportCreationRequest> => {
				return [...queuedReports].sort(
				(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
				a.id.localeCompare(b.id),
				);
				};

				describe('processReportStoreOperations', () => {
				it('should return the original reports if no operations are processed', () => {
				const reportStoreOps = [];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(mockReports);
				});

				it('should replace the report with the given id', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportIos,
				id: '2',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportIos,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);

				expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
				});

				it('should handle an empty reports with replace operation', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportWeb,
				id: '1',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should remove reports with given ids', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should handle empty reports with remove_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});

				it('should remove all reports', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual([]);
				});

				it('should handle empty reports with remove_all_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});
				});