Page MenuHomePhabricator
Differential D7936

[CommCoreModule] implement getting report store from database
ClosedPublic
Actions

Authored by kamil on Tue, May 23, 3:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 31, 2:54 PM
Unknown Object (File)
Tue, May 23, 6:21 PM
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM716822a273ea: [CommCoreModule] implement getting report store from database
Summary

Following the same approach as for different stores

Depends on D7934

Test Plan

Check if data is properly fetched from database

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, May 23, 3:08 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptTue, May 23, 3:08 AM
Harbormaster completed remote builds in B19646: Diff 26854.Tue, May 23, 3:26 AM
kamil added a child revision: D7937: [native] start processing report store operations on database.Tue, May 23, 3:28 AM
kamil updated this revision to Diff 26919.Tue, May 23, 4:33 PM

minor fixes

Harbormaster completed remote builds in B19706: Diff 26919.Tue, May 23, 4:50 PM
kamil published this revision for review.Tue, May 23, 4:55 PM
tomek accepted this revision.Wed, May 24, 2:01 AM
This revision is now accepted and ready to land.Wed, May 24, 2:01 AM
kamil added a child revision: D7975: [CommCoreModule] implement synchronous report store operations.Thu, May 25, 7:26 AM
kamil removed a child revision: D7937: [native] start processing report store operations on database.Thu, May 25, 7:57 AM
kamil mentioned this in D8008: [CommCoreModule] add table and methods for report store.Mon, May 29, 4:30 AM
kamil updated this revision to Diff 27149.Mon, May 29, 4:44 AM

rebase

Harbormaster completed remote builds in B19822: Diff 27149.Mon, May 29, 5:02 AM
Closed by commit rCOMM716822a273ea: [CommCoreModule] implement getting report store from database (authored by kamil). · Explain WhyMon, May 29, 5:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM716822a273ea: [CommCoreModule] implement getting report store from database.
kamil added a child revision: D7937: [native] start processing report store operations on database.Wed, May 31, 8:28 AM
kamil removed a child revision: D7937: [native] start processing report store operations on database.Wed, May 31, 8:29 AM

Revision Contents
Changeset List

PathSize
lib/
ops/
4 lines
types/
6 lines
native/
cpp/
CommonCpp/
NativeModules/
25 lines
web/
database/
worker/
1 line

Diff 27152

View Options

lib/ops/report-store-ops.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

web/database/worker/db-worker.js

Loading...