Convert logic for ops approach.
Depends on D7932
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 148–164 ↗ | (On Diff #26844) | It's quite strange that this happens outside the actions, but it follows the convention from the original code. |
Comment Actions
rebase
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 148–164 ↗ | (On Diff #26844) | Yeah, but it'll be hard to fix. That's because some inconsistencies are not added to store by dispatching action but directly from other reducers as reduceReportStore argument |
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 148 | I think this check should've been newReports.length > 0. As a result, we end up changing reportStore on every since action. Looking at the code, this shouldn't have a very negative effect (I don't think it causes any components to rerender, since processReportStoreOperations keeps state.queuedReports if reportStoreOperations is empty). However, it is causing ENG-5694 | |