Paths

Table of Contentst

-
lib/reducers/
-
reducers/
-
report-store-reducer.js

[lib] refactor handling new inconsistencies in report store reducer for using operations
ClosedPublic
Actions

Authored by kamil on May 23 2023, 1:33 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM633cf852f5ea: [lib] refactor handling new inconsistencies in report store reducer for using…

Summary

Convert logic for ops approach.

Depends on D7932

Test Plan

Tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 23 2023, 1:33 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 1:33 AM

Harbormaster completed remote builds in B19636: Diff 26844.May 23 2023, 1:52 AM

kamil published this revision for review.May 23 2023, 1:58 AM

kamil added a child revision: D7937: [native] start processing report store operations on database.May 23 2023, 3:28 AM

tomek accepted this revision.May 24 2023, 3:08 AM

tomek added inline comments.

lib/reducers/report-store-reducer.js
148–164 ↗	(On Diff #26844)	It's quite strange that this happens outside the actions, but it follows the convention from the original code.

This revision is now accepted and ready to land.May 24 2023, 3:08 AM

rebase

lib/reducers/report-store-reducer.js
148–164 ↗	(On Diff #26844)	Yeah, but it'll be hard to fix. That's because some inconsistencies are not added to store by dispatching action but directly from other reducers as `reduceReportStore` argument

Harbormaster completed remote builds in B19818: Diff 27137.May 29 2023, 4:09 AM

Closed by commit rCOMM633cf852f5ea: [lib] refactor handling new inconsistencies in report store reducer for using… (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM633cf852f5ea: [lib] refactor handling new inconsistencies in report store reducer for using….

ashoat added inline comments.Nov 10 2023, 8:17 AM

lib/reducers/report-store-reducer.js
148	I think this check should've been `newReports.length > 0`. As a result, we end up changing `reportStore` on every since action. Looking at the code, this shouldn't have a very negative effect (I don't think it causes any components to rerender, since `processReportStoreOperations` keeps `state.queuedReports` if `reportStoreOperations` is empty). However, it is causing ENG-5694

ashoat mentioned this in D9823: [lib] Fix persisting of privacy settings.Nov 10 2023, 8:30 AM

ashoat mentioned this in rCOMMbbd041fd4af0: [lib] Fix persisting of privacy settings.Nov 10 2023, 12:48 PM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

report-store-reducer.js

31 lines

Diff 27145

View Options

lib/reducers/report-store-reducer.js

Show All 9 Lines	"icons": [
"width": 1317,		"width": 1317,
"isMulticolor": false,		"isMulticolor": false,
"isMulticolor2": false,		"isMulticolor2": false,
"grid": 0,		"grid": 0,
"tags": ["cloud-filled"]		"tags": ["cloud-filled"]
},		},
"attrs": [{}],		"attrs": [{}],
"properties": {		"properties": {
"order": 3,		"order": 361,
"id": 5,		"id": 0,
"name": "cloud-filled",		"name": "cloud-filled",
"prevSize": 32,		"prevSize": 32,
"code": 59648		"code": 59648
},		},
"setIdx": 0,		"setIdx": 1,
"setId": 3,		"setId": 10,
"iconIdx": 0		"iconIdx": 0
},		},
{		{
"icon": {		"icon": {
"paths": [		"paths": [
"M269.474 215.579h-107.789c-89.315 0-161.684 72.369-161.684 161.684v107.789c0 89.315 72.369 161.684 161.684 161.684h107.789v-431.158zM188.632 565.895h-26.947c-44.667 0-80.842-36.175-80.842-80.842v-107.789l0.37-7.789c3.915-41.009 38.432-73.053 80.472-73.053h26.947v269.474z",		"M269.474 215.579h-107.789c-89.315 0-161.684 72.369-161.684 161.684v107.789c0 89.315 72.369 161.684 161.684 161.684h107.789v-431.158zM188.632 565.895h-26.947c-44.667 0-80.842-36.175-80.842-80.842v-107.789l0.37-7.789c3.915-41.009 38.432-73.053 80.472-73.053h26.947v269.474z",
"M432.547 692.53l-40.308 131.593c-8.427 27.442 6.22 56.736 33.257 66.47l310.226 112.604c30.575 10.982 63.84-7.063 70.962-38.789l43.017-187.193c6.901-29.975-12.695-59.706-43.014-65.12l-312.862-56.757c-26.906-4.991-53.277 11.028-61.278 37.193zM502.838 739.059l261.767 47.535-29.912 130.21-257.725-93.507 25.869-84.237z",		"M432.547 692.53l-40.308 131.593c-8.427 27.442 6.22 56.736 33.257 66.47l310.226 112.604c30.575 10.982 63.84-7.063 70.962-38.789l43.017-187.193c6.901-29.975-12.695-59.706-43.014-65.12l-312.862-56.757c-26.906-4.991-53.277 11.028-61.278 37.193zM502.838 739.059l261.767 47.535-29.912 130.21-257.725-93.507 25.869-84.237z",
"M1065.206 16.225l-700.699 170.863c-24.102 5.81-41.139 27.454-41.139 52.367v406.797c0 25.494 17.848 47.549 42.903 52.733l700.386 149.452c33.538 7.14 65.133-18.473 65.133-52.735v-727.094c0-34.912-32.694-60.586-66.583-52.383zM1050.947 102.885v659.51l-646.737-137.971v-363.843l646.737-157.696z"		"M1065.206 16.225l-700.699 170.863c-24.102 5.81-41.139 27.454-41.139 52.367v406.797c0 25.494 17.848 47.549 42.903 52.733l700.386 149.452c33.538 7.14 65.133-18.473 65.133-52.735v-727.094c0-34.912-32.694-60.586-66.583-52.383zM1050.947 102.885v659.51l-646.737-137.971v-363.843l646.737-157.696z"
],		],
"attrs": [{}, {}, {}],		"attrs": [{}, {}, {}],
"width": 1132,		"width": 1132,
"isMulticolor": false,		"isMulticolor": false,
"isMulticolor2": false,		"isMulticolor2": false,
"grid": 0,		"grid": 0,
"tags": ["megaphone"]		"tags": ["megaphone"]
},		},
"attrs": [{}, {}, {}],		"attrs": [{}, {}, {}],
"properties": {		"properties": {
"order": 4,		"order": 362,
"id": 4,		"id": 1,
"name": "megaphone",		"name": "megaphone",
"prevSize": 32,		"prevSize": 32,
"code": 59649		"code": 59649
},		},
"setIdx": 0,		"setIdx": 1,
"setId": 3,		"setId": 10,
"iconIdx": 1		"iconIdx": 1
},		},
{		{
"icon": {		"icon": {
"paths": [		"paths": [
"M34.752 441.984c-31.040 25.6-31.040 73.152 0 98.752l507.456 418.56c41.728 34.368 104.704 4.736 104.704-49.408v-255.808c239.232 11.456 449.728 90.496 586.752 207.936 30.016 25.792 78.592 12.864 78.592-26.752 0-273.152-290.176-498.624-665.344-531.904v-230.464c0-54.144-62.976-83.84-104.704-49.408l-507.456 418.496z"		"M34.752 441.984c-31.040 25.6-31.040 73.152 0 98.752l507.456 418.56c41.728 34.368 104.704 4.736 104.704-49.408v-255.808c239.232 11.456 449.728 90.496 586.752 207.936 30.016 25.792 78.592 12.864 78.592-26.752 0-273.152-290.176-498.624-665.344-531.904v-230.464c0-54.144-62.976-83.84-104.704-49.408l-507.456 418.496z"
],		],
"attrs": [{}],		"attrs": [{}],
"width": 1344,		"width": 1344,
"isMulticolor": false,		"isMulticolor": false,
"isMulticolor2": false,		"isMulticolor2": false,
"grid": 0,		"grid": 0,
"tags": ["reply-filled"]		"tags": ["reply-filled"]
},		},
"attrs": [{}],		"attrs": [{}],
"properties": {		"properties": {
"order": 5,		"order": 363,
"id": 3,		"id": 2,
"name": "reply-filled",		"name": "reply-filled",
"prevSize": 32,		"prevSize": 32,
"code": 59650		"code": 59650
},		},
"setIdx": 0,		"setIdx": 1,
"setId": 3,		"setId": 10,
"iconIdx": 2		"iconIdx": 2
},		},
{		{
"icon": {		"icon": {
"paths": [		"paths": [
"M541.796 47.496l-477.596 393.871c-51.125 42.165-51.125 120.485-0.001 162.649l484.365 399.092c68.601 48.299 165.707-0.256 165.707-86.508l-0.045-192.392 2.853 0.288c190.546 17.759 360.768 83.569 474.854 181.349 55.99 48.111 148.545 19.231 148.545-59.48l-0.258-14.54c-9.266-260.857-267.192-474.604-609.354-524.327l-16.639-2.287 0.045-176.369c0-89.143-103.724-138.076-172.474-81.347zM623.917 128.843v258.254l41.185 3.653 18.536 1.824c319.722 34.592 557.376 222.822 566.23 441.162l0.030 2.811 0.876 0.732c-140.156-120.125-349.725-195.561-579.519-206.565l-47.337-2.267v288.152c0 12.742-14.817 19.726-24.648 11.63l-477.581-393.918c-7.306-6.026-7.306-17.215-0.002-23.24l477.614-393.886c9.807-8.092 24.616-1.106 24.616 11.656z"		"M541.796 47.496l-477.596 393.871c-51.125 42.165-51.125 120.485-0.001 162.649l484.365 399.092c68.601 48.299 165.707-0.256 165.707-86.508l-0.045-192.392 2.853 0.288c190.546 17.759 360.768 83.569 474.854 181.349 55.99 48.111 148.545 19.231 148.545-59.48l-0.258-14.54c-9.266-260.857-267.192-474.604-609.354-524.327l-16.639-2.287 0.045-176.369c0-89.143-103.724-138.076-172.474-81.347zM623.917 128.843v258.254l41.185 3.653 18.536 1.824c319.722 34.592 557.376 222.822 566.23 441.162l0.030 2.811 0.876 0.732c-140.156-120.125-349.725-195.561-579.519-206.565l-47.337-2.267v288.152c0 12.742-14.817 19.726-24.648 11.63l-477.581-393.918c-7.306-6.026-7.306-17.215-0.002-23.24l477.614-393.886c9.807-8.092 24.616-1.106 24.616 11.656z"
],		],
"attrs": [{}],		"attrs": [{}],
"width": 1385,		"width": 1385,
"isMulticolor": false,		"isMulticolor": false,
"isMulticolor2": false,		"isMulticolor2": false,
"grid": 0,		"grid": 0,
"tags": ["reply"]		"tags": ["reply"]
},		},
"attrs": [{}],		"attrs": [{}],
"properties": {		"properties": {
"order": 6,		"order": 364,
"id": 2,		"id": 3,
"name": "reply",		"name": "reply",
"prevSize": 32,		"prevSize": 32,
"code": 59651		"code": 59651
},		},
"setIdx": 0,		"setIdx": 1,
"setId": 3,		"setId": 10,
"iconIdx": 3		"iconIdx": 3
},		},
{		{
"icon": {		"icon": {
"paths": [		"paths": [
"M474.675 0c262.144 0 474.573 212.531 474.573 474.675 0 76.39-17.92 148.634-50.176 212.582l90.112 269.312c6.656 20.019-12.8 39.066-32.768 32.41l-269.21-89.805c-63.949 32.102-136.141 50.125-212.531 50.125-262.144 0-474.675-212.48-474.675-474.624s212.531-474.675 474.675-474.675zM576 537.6h-281.6c-21.197 0-38.4 17.203-38.4 38.4s17.203 38.4 38.4 38.4h281.6c21.197 0 38.4-17.203 38.4-38.4s-17.203-38.4-38.4-38.4zM678.4 332.8h-384c-21.197 0-38.4 17.203-38.4 38.4s17.203 38.4 38.4 38.4h384c21.197 0 38.4-17.203 38.4-38.4s-17.203-38.4-38.4-38.4z"		"M474.675 0c262.144 0 474.573 212.531 474.573 474.675 0 76.39-17.92 148.634-50.176 212.582l90.112 269.312c6.656 20.019-12.8 39.066-32.768 32.41l-269.21-89.805c-63.949 32.102-136.141 50.125-212.531 50.125-262.144 0-474.675-212.48-474.675-474.624s212.531-474.675 474.675-474.675zM576 537.6h-281.6c-21.197 0-38.4 17.203-38.4 38.4s17.203 38.4 38.4 38.4h281.6c21.197 0 38.4-17.203 38.4-38.4s-17.203-38.4-38.4-38.4zM678.4 332.8h-384c-21.197 0-38.4 17.203-38.4 38.4s17.203 38.4 38.4 38.4h384c21.197 0 38.4-17.203 38.4-38.4s-17.203-38.4-38.4-38.4z"
],		],
"attrs": [{}],		"attrs": [{}],
"isMulticolor": false,		"isMulticolor": false,
"isMulticolor2": false,		"isMulticolor2": false,
"grid": 0,		"grid": 0,
"tags": ["sidebar-filled"]		"tags": ["sidebar-filled"]
},		},
"attrs": [{}],		"attrs": [{}],
"properties": {		"properties": {
"order": 7,		"order": 365,
"id": 1,		"id": 4,
"name": "sidebar-filled",		"name": "sidebar-filled",
"prevSize": 32,		"prevSize": 32,
"code": 59652		"code": 59652
},		},
"setIdx": 0,		"setIdx": 1,
"setId": 3,		"setId": 10,
"iconIdx": 4		"iconIdx": 4
},		},
{		{
"icon": {		"icon": {
"paths": [		"paths": [
"M665.6 345.6c21.208 0 38.4 17.192 38.4 38.4s-17.192 38.4-38.4 38.4h-358.4c-21.208 0-38.4-17.192-38.4-38.4s17.192-38.4 38.4-38.4h358.4z",		"M665.6 345.6c21.208 0 38.4 17.192 38.4 38.4s-17.192 38.4-38.4 38.4h-358.4c-21.208 0-38.4-17.192-38.4-38.4s17.192-38.4 38.4-38.4h358.4z",
"M563.2 550.4c21.208 0 38.4 17.192 38.4 38.4s-17.192 38.4-38.4 38.4h-256c-21.208 0-38.4-17.192-38.4-38.4s17.192-38.4 38.4-38.4h256z",		"M563.2 550.4c21.208 0 38.4 17.192 38.4 38.4s-17.192 38.4-38.4 38.4h-256c-21.208 0-38.4-17.192-38.4-38.4s17.192-38.4 38.4-38.4h256z",
"M486.4 12.798h-25.6c-118.056 6.471-227.811 55.51-310.252 137.728-82.163 81.94-130.973 191.516-137.684 308.067l-0.064 27.807c0 74.262 17.062 146.804 50.263 211.988 39.519 78.593 99.753 144.636 174.253 190.782 74.641 46.233 160.988 70.774 249.060 70.83l18.363-0.319c61.115-2.262 121.182-16.49 176.922-41.912l1.86-0.932 277.137 92.392 4.983 1.317c28.090 5.512 53.040-21.538 43.589-49.89l-92.391-277.087-7.101 14.818c33.201-65.184 50.263-137.726 50.263-211.988 0-87.918-24.51-174.121-70.766-248.909-46.161-74.692-112.394-135.147-191.082-174.547-65.712-33.135-138.226-50.311-211.752-50.146zM462.92 89.54l23.566 0.058c61.539-0.139 122.147 14.217 177.184 41.969 66.066 33.080 121.575 83.747 160.24 146.31 38.756 62.664 59.289 134.877 59.289 208.523 0 62.263-14.251 122.853-41.897 177.132l-2.334 5.658c-2.49 7.731-2.479 16.109 0.122 23.914l72.986 218.973-218.974-72.985c-9.704-3.235-20.298-2.464-29.432 2.142-55.037 27.752-115.645 42.108-177.184 41.968-73.881-0.047-146.238-20.612-208.731-59.32-62.41-38.657-112.911-94.028-146.169-160.171-27.736-54.457-41.987-115.046-41.987-177.309v-25.6c5.567-95.58 46.444-187.345 115.18-255.895 69.093-68.906 161.057-109.996 258.14-115.365z"		"M486.4 12.798h-25.6c-118.056 6.471-227.811 55.51-310.252 137.728-82.163 81.94-130.973 191.516-137.684 308.067l-0.064 27.807c0 74.262 17.062 146.804 50.263 211.988 39.519 78.593 99.753 144.636 174.253 190.782 74.641 46.233 160.988 70.774 249.060 70.83l18.363-0.319c61.115-2.262 121.182-16.49 176.922-41.912l1.86-0.932 277.137 92.392 4.983 1.317c28.090 5.512 53.040-21.538 43.589-49.89l-92.391-277.087-7.101 14.818c33.201-65.184 50.263-137.726 50.263-211.988 0-87.918-24.51-174.121-70.766-248.909-46.161-74.692-112.394-135.147-191.082-174.547-65.712-33.135-138.226-50.311-211.752-50.146zM462.92 89.54l23.566 0.058c61.539-0.139 122.147 14.217 177.184 41.969 66.066 33.080 121.575 83.747 160.24 146.31 38.756 62.664 59.289 134.877 59.289 208.523 0 62.263-14.251 122.853-41.897 177.132l-2.334 5.658c-2.49 7.731-2.479 16.109 0.122 23.914l72.986 218.973-218.974-72.985c-9.704-3.235-20.298-2.464-29.432 2.142-55.037 27.752-115.645 42.108-177.184 41.968-73.881-0.047-146.238-20.612-208.731-59.32-62.41-38.657-112.911-94.028-146.169-160.171-27.736-54.457-41.987-115.046-41.987-177.309v-25.6c5.567-95.58 46.444-187.345 115.18-255.895 69.093-68.906 161.057-109.996 258.14-115.365z"
],		],
"attrs": [{}, {}, {}],		"attrs": [{}, {}, {}],
"isMulticolor": false,		"isMulticolor": false,
"isMulticolor2": false,		"isMulticolor2": false,
"grid": 0,		"grid": 0,
"tags": ["sidebar"]		"tags": ["sidebar"]
},		},
"attrs": [{}, {}, {}],		"attrs": [{}, {}, {}],
"properties": {		"properties": {
"order": 8,		"order": 366,
"id": 0,		"id": 5,
"name": "sidebar",		"name": "sidebar",
"prevSize": 32,		"prevSize": 32,
"code": 59653		"code": 59653
},		},
"setIdx": 0,		"setIdx": 1,
"setId": 3,		"setId": 10,
"iconIdx": 5		"iconIdx": 5
		},
		{
		"icon": {
		"paths": [
		"M579.231 341.333h-362.019c-57.125 0-103.434 46.309-103.434 103.434v362.019c0 57.128 46.309 103.435 103.434 103.435h362.019c57.128 0 103.435-46.308 103.435-103.435v-362.019c0-57.125-46.308-103.434-103.435-103.434z",
		"M444.768 113.778h362.019c57.128 0 103.435 46.309 103.435 103.434v362.019c0 57.128-46.308 103.435-103.435 103.435h-10.342v-341.333c0-57.125-56.65-113.778-113.778-113.778h-341.333v-10.344c0-57.125 46.309-103.434 103.434-103.434z",
		"M227.556 341.333h341.333c62.838 0 113.778 50.94 113.778 113.778v341.333c0 62.838-50.94 113.778-113.778 113.778h-341.333c-62.838 0-113.778-50.94-113.778-113.778v-341.333c0-62.838 50.94-113.778 113.778-113.778z",
		"M455.111 113.778c-62.838 0-113.778 50.94-113.778 113.778h227.556c125.673 0 227.556 101.88 227.556 227.556v227.556c62.839 0 113.778-50.938 113.778-113.778v-341.333c0-62.838-50.938-113.778-113.778-113.778h-341.333z"
		],
		"attrs": [],
		"isMulticolor": false,
		"isMulticolor2": false,
		"grid": 0,
		"tags": ["copy-filled"],
		"colorPermutations": {}
		},
		"attrs": [],
		"properties": {
		"order": 376,
		"id": 7,
		"name": "copy-filled",
		"prevSize": 32
		},
		"setIdx": 1,
		"setId": 10,
		"iconIdx": 6
}		}
],		],
"height": 1024,		"height": 1024,
"metadata": { "name": "CommIcons" },		"metadata": { "name": "CommIcons" },
"preferences": {		"preferences": {
"showGlyphs": true,		"showGlyphs": true,
"showQuickUse": true,		"showQuickUse": true,
"showQuickUse2": true,		"showQuickUse2": true,
Show All 30 Lines

[lib] refactor handling new inconsistencies in report store reducer for using operationsClosedPublicActions