Page MenuHomePhabricator
Differential D7933

[lib] refactor handling new inconsistencies in report store reducer for using operations
ClosedPublic
Actions

Authored by kamil on Tue, May 23, 1:33 AM.

Details

Reviewers
tomek
michal
Commits
rCOMM633cf852f5ea: [lib] refactor handling new inconsistencies in report store reducer for using…
Summary

Convert logic for ops approach.

Depends on D7932

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, May 23, 1:33 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptTue, May 23, 1:33 AM
Harbormaster completed remote builds in B19636: Diff 26844.Tue, May 23, 1:52 AM
kamil published this revision for review.Tue, May 23, 1:58 AM
kamil added a child revision: D7937: [native] start processing report store operations on database.Tue, May 23, 3:28 AM
tomek accepted this revision.Wed, May 24, 3:08 AM
tomek added inline comments.
lib/reducers/report-store-reducer.js
148–164 ↗(On Diff #26844)

It's quite strange that this happens outside the actions, but it follows the convention from the original code.

This revision is now accepted and ready to land.Wed, May 24, 3:08 AM
kamil updated this revision to Diff 27137.Mon, May 29, 3:50 AM

rebase

lib/reducers/report-store-reducer.js
148–164 ↗(On Diff #26844)

Yeah, but it'll be hard to fix. That's because some inconsistencies are not added to store by dispatching action but directly from other reducers as reduceReportStore argument

Harbormaster completed remote builds in B19818: Diff 27137.Mon, May 29, 4:09 AM
Closed by commit rCOMM633cf852f5ea: [lib] refactor handling new inconsistencies in report store reducer for using… (authored by kamil). · Explain WhyMon, May 29, 4:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM633cf852f5ea: [lib] refactor handling new inconsistencies in report store reducer for using….

Revision Contents
Changeset List

PathSize
lib/
reducers/
31 lines

Diff 27145

View Options

lib/reducers/report-store-reducer.js

Loading...