[lib] refactor handling new inconsistencies in report store reducer for using operations
ClosedPublic
Actions

Authored by kamil on May 23 2023, 1:33 AM.

Details

Reviewers

tomek
michal

Commits

Summary

Convert logic for ops approach.

Depends on D7932

Test Plan

Tests

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kamil held this revision as a draft.

kamil published this revision for review.May 23 2023, 1:58 AM

tomek added inline comments.

lib/reducers/report-store-reducer.js
148–164 ↗	(On Diff #26844)	It's quite strange that this happens outside the actions, but it follows the convention from the original code.

This revision is now accepted and ready to land.May 24 2023, 3:08 AM

rebase

lib/reducers/report-store-reducer.js
148–164 ↗	(On Diff #26844)	Yeah, but it'll be hard to fix. That's because some inconsistencies are not added to store by dispatching action but directly from other reducers as `reduceReportStore` argument

This revision was automatically updated to reflect the committed changes.

lib/reducers/report-store-reducer.js
148	I think this check should've been `newReports.length > 0`. As a result, we end up changing `reportStore` on every since action. Looking at the code, this shouldn't have a very negative effect (I don't think it causes any components to rerender, since `processReportStoreOperations` keeps `state.queuedReports` if `reportStoreOperations` is empty). However, it is causing ENG-5694