Page MenuHomePhabricator

[lib] assign local id to report while creating
ClosedPublic

Authored by kamil on May 22 2023, 6:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 12:49 PM
Unknown Object (File)
Fri, Jun 21, 8:00 AM
Unknown Object (File)
Sun, Jun 16, 6:24 PM
Unknown Object (File)
Sun, Jun 16, 1:52 AM
Unknown Object (File)
Sat, Jun 15, 10:09 AM
Unknown Object (File)
Sat, Jun 15, 9:29 AM
Unknown Object (File)
Thu, Jun 13, 3:55 AM
Unknown Object (File)
Wed, Jun 12, 8:35 PM
Subscribers

Details

Summary

Adding id while adding new report to store.

Depends on D7912

Test Plan

Make sure each report type will have an assigned id.

After this, I made id field mandatory and checked for flow errors which should make sure that it was added in all places

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 23 2023, 1:40 AM
kamil edited the test plan for this revision. (Show Details)

It might be a good idea to create an intermediate function that generates the id. At this point that function would just return getUUID(), but if we ever decide to change id scheme, having this function would be really helpful.

This revision is now accepted and ready to land.May 23 2023, 3:15 AM
kamil edited the test plan for this revision. (Show Details)

add intermediate function