Page MenuHomePhabricator

[lib] assign local id to report while creating

Authored by kamil on Mon, May 22, 6:46 AM.
Referenced Files
Unknown Object (File)
Wed, Jun 7, 7:30 AM
Unknown Object (File)
Tue, Jun 6, 4:36 AM
Unknown Object (File)
Tue, Jun 6, 1:56 AM
Unknown Object (File)
Mon, Jun 5, 10:52 AM
Unknown Object (File)
Sat, Jun 3, 12:14 PM
Unknown Object (File)
Wed, May 31, 4:45 AM



Adding id while adding new report to store.

Depends on D7912

Test Plan

Make sure each report type will have an assigned id.

After this, I made id field mandatory and checked for flow errors which should make sure that it was added in all places

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Tue, May 23, 1:40 AM
kamil edited the test plan for this revision. (Show Details)

It might be a good idea to create an intermediate function that generates the id. At this point that function would just return getUUID(), but if we ever decide to change id scheme, having this function would be really helpful.

This revision is now accepted and ready to land.Tue, May 23, 3:15 AM
kamil edited the test plan for this revision. (Show Details)

add intermediate function