Page MenuHomePhabricator

[lib] add operation for removing all reports on login/logout
ClosedPublic

Authored by kamil on May 22 2023, 10:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 4:47 PM
Unknown Object (File)
Sat, Jun 15, 2:57 AM
Unknown Object (File)
Thu, Jun 13, 8:10 AM
Unknown Object (File)
Wed, Jun 12, 6:20 AM
Unknown Object (File)
Tue, Jun 4, 7:39 PM
Unknown Object (File)
Mon, Jun 3, 9:12 PM
Unknown Object (File)
Mon, Jun 3, 9:12 PM
Unknown Object (File)
Mon, Jun 3, 9:12 PM
Subscribers

Details

Summary

In this case this change is very simple - so generating only db operations without calling processReportStoreOperations

Depends on D7921

Test Plan
  1. Logout/login user (create some reports previously)
  2. tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 23 2023, 1:52 AM
tomek added inline comments.
lib/reducers/report-store-reducer.js
83 ↗(On Diff #26837)

Are you sure we should remove these on login?

This revision is now accepted and ready to land.May 24 2023, 2:10 AM

rebase

lib/reducers/report-store-reducer.js
83 ↗(On Diff #26837)

yes, operations should maintain previous logic, and on the login queuedReports was returned as an empty array