Page MenuHomePhabricator

[web-db] add migration logic to SQLite on web
ClosedPublic

Authored by kamil on May 25 2023, 10:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 3:43 AM
Unknown Object (File)
Tue, Jun 11, 4:19 PM
Unknown Object (File)
Mon, Jun 3, 9:14 PM
Unknown Object (File)
Mon, Jun 3, 9:14 PM
Unknown Object (File)
Mon, Jun 3, 8:43 PM
Unknown Object (File)
Sun, Jun 2, 9:10 AM
Unknown Object (File)
Sun, May 26, 11:47 PM
Unknown Object (File)
May 8 2024, 2:15 PM
Subscribers

Details

Summary

Similar to keyserver logic. Currently, nothing is happening when migration will fail but there is a followup task to improve error handling on web.

Depends on D7939

Test Plan
  1. Check if migrate is called when using old db
  2. Check in migrate is not called when creating fresh database
  3. Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 25 2023, 1:45 PM

I think you could test the migration code by mocking the migrations variable with jest, but not sure if that's worth it.

This revision is now accepted and ready to land.May 30 2023, 8:26 AM