Page MenuHomePhabricator
Differential D7982

[web-db] add migration logic to SQLite on web
ClosedPublic
Actions

Authored by kamil on May 25 2023, 10:25 AM.
Tags
None
Referenced Files
F3513789: D7982.diff
Sun, Dec 22, 2:06 AM
Unknown Object (File)
Mon, Dec 16, 6:08 AM
Unknown Object (File)
Mon, Dec 16, 6:08 AM
Unknown Object (File)
Mon, Dec 16, 6:08 AM
Unknown Object (File)
Mon, Dec 16, 6:00 AM
Unknown Object (File)
Nov 10 2024, 6:58 AM
Unknown Object (File)
Oct 10 2024, 12:32 AM
Unknown Object (File)
Sep 29 2024, 1:18 AM
View All 90 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM35313865ac8f: [web-db] add migration logic to SQLite on web
Summary

Similar to keyserver logic. Currently, nothing is happening when migration will fail but there is a followup task to improve error handling on web.

Depends on D7939

Test Plan
  1. Check if migrate is called when using old db
  2. Check in migrate is not called when creating fresh database
  3. Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.May 25 2023, 10:25 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 25 2023, 10:25 AM
kamil added a child revision: D7983: [web-db] implement SQL queries for report store.May 25 2023, 10:28 AM
Harbormaster completed remote builds in B19775: Diff 27067.May 25 2023, 10:43 AM
kamil published this revision for review.May 25 2023, 1:45 PM
michal accepted this revision.May 30 2023, 8:26 AM

I think you could test the migration code by mocking the migrations variable with jest, but not sure if that's worth it.

This revision is now accepted and ready to land.May 30 2023, 8:26 AM
Closed by commit rCOMM35313865ac8f: [web-db] add migration logic to SQLite on web (authored by kamil). · Explain WhyMay 31 2023, 10:11 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM35313865ac8f: [web-db] add migration logic to SQLite on web.

Revision Contents
Changeset List

PathSize
web/
database/
queries/
33 lines
12 lines
utils/
8 lines
worker/
6 lines

Diff 27310

View Options

web/database/queries/db-queries.js

Loading...
View Options

web/database/sql-js.test.js

Loading...
View Options

web/database/utils/migrations.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...