Page MenuHomePhabricator

[lib] add local id field to existing reports
ClosedPublic

Authored by kamil on May 22 2023, 6:41 AM.
Tags
None
Referenced Files
F2032797: D7912.id27127.diff
Tue, Jun 18, 3:39 AM
Unknown Object (File)
Tue, Jun 11, 9:46 PM
Unknown Object (File)
Tue, Jun 11, 1:30 PM
Unknown Object (File)
Sat, Jun 8, 12:42 AM
Unknown Object (File)
Thu, Jun 6, 8:24 PM
Unknown Object (File)
Mon, Jun 3, 9:10 PM
Unknown Object (File)
Mon, Jun 3, 9:10 PM
Unknown Object (File)
Mon, Jun 3, 9:10 PM
Subscribers

Details

Summary

This is probably not necessary as I don't think that anyone has some persisted, not sent reports, but adding this for clarity.

Depends on D7910

Test Plan

Make sure that there are some reports in store (e.g. throw in keyserver endpoint and create some inconsistencies). Then verify that id was added.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
lib/utils/report-utils.js
30–37 ↗(On Diff #26779)

this function will be re-used in next diff

kamil published this revision for review.May 23 2023, 1:37 AM
tomek added inline comments.
lib/utils/report-utils.js
35 ↗(On Diff #26779)

Should we do this only for reports which don't have the id? I guess in the migration it doesn't matter, but maybe for other usages of this function will?

This revision is now accepted and ready to land.May 23 2023, 3:14 AM

move code directly to migration

lib/utils/report-utils.js
35 ↗(On Diff #26779)

it turned out that this was a bad assumption - this function will not be used in more places.

Also, because id will be mandatory function argument type is not proper - I'll put this code directly into migration.