Page MenuHomePhabricator
Differential D7934

[CommCoreModule] implement report store operations
ClosedPublic
Actions

Authored by kamil on May 23 2023, 2:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 10:54 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:24 AM
Unknown Object (File)
Mar 5 2025, 4:00 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMMd99f525fc5ff: [CommCoreModule] implement report store operations
Summary

Following the same approach as for different stores.

Depends on D7918

Test Plan

Create each operation in js and check in database if it works properly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.May 23 2023, 2:26 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 2:26 AM
Harbormaster completed remote builds in B19640: Diff 26848.May 23 2023, 2:45 AM
kamil added a child revision: D7936: [CommCoreModule] implement getting report store from database.May 23 2023, 3:08 AM
kamil added inline comments.May 23 2023, 3:43 AM
native/schema/CommCoreModuleSchema.js
8 ↗(On Diff #26848)

I will this shortly

kamil published this revision for review.May 23 2023, 4:24 PM
kamil updated this revision to Diff 26918.May 23 2023, 4:30 PM

fix import

Harbormaster completed remote builds in B19705: Diff 26918.May 23 2023, 4:48 PM
tomek accepted this revision.May 24 2023, 1:54 AM
This revision is now accepted and ready to land.May 24 2023, 1:54 AM
kamil updated this revision to Diff 27148.May 29 2023, 4:44 AM

rebase

Harbormaster completed remote builds in B19821: Diff 27148.May 29 2023, 5:01 AM
Closed by commit rCOMMd99f525fc5ff: [CommCoreModule] implement report store operations (authored by kamil). · Explain WhyMay 29 2023, 5:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd99f525fc5ff: [CommCoreModule] implement report store operations.

Revision Contents
Changeset List

PathSize
lib/
ops/
10 lines
native/
cpp/
CommonCpp/
NativeModules/
3 lines
77 lines
57 lines
_generated/
schema/
4 lines

Diff 27151

View Options

lib/ops/report-store-ops.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

native/cpp/CommonCpp/NativeModules/ReportStoreOperations.h

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...