Page MenuHomePhabricator
Differential D7934

[CommCoreModule] implement report store operations
ClosedPublic
Actions

Authored by kamil on May 23 2023, 2:26 AM.
Tags
None
Referenced Files
F1552090: D7934.id27151.diff
Tue, Apr 16, 3:11 AM
F1551093: D7934.diff
Mon, Apr 15, 8:37 PM
F1550631: D7934.id27148.diff
Mon, Apr 15, 4:23 PM
Unknown Object (File)
Mon, Apr 15, 3:34 AM
Unknown Object (File)
Sun, Apr 14, 7:58 AM
Unknown Object (File)
Sat, Apr 13, 11:30 AM
Unknown Object (File)
Sat, Apr 13, 11:00 AM
Unknown Object (File)
Sat, Apr 13, 7:57 AM
View All 48 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMMd99f525fc5ff: [CommCoreModule] implement report store operations
Summary

Following the same approach as for different stores.

Depends on D7918

Test Plan

Create each operation in js and check in database if it works properly

Diff Detail

Repository
rCOMM Comm
Branch
reports-native
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 2:26 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 2:26 AM
Harbormaster completed remote builds in B19640: Diff 26848.May 23 2023, 2:45 AM
kamil added a child revision: D7936: [CommCoreModule] implement getting report store from database.May 23 2023, 3:08 AM
kamil added inline comments.May 23 2023, 3:43 AM
native/schema/CommCoreModuleSchema.js
8

I will this shortly

kamil published this revision for review.May 23 2023, 4:24 PM
kamil updated this revision to Diff 26918.May 23 2023, 4:30 PM

fix import

Harbormaster completed remote builds in B19705: Diff 26918.May 23 2023, 4:48 PM
tomek accepted this revision.May 24 2023, 1:54 AM
This revision is now accepted and ready to land.May 24 2023, 1:54 AM
kamil updated this revision to Diff 27148.May 29 2023, 4:44 AM

rebase

Harbormaster completed remote builds in B19821: Diff 27148.May 29 2023, 5:01 AM
Closed by commit rCOMMd99f525fc5ff: [CommCoreModule] implement report store operations (authored by kamil). · Explain WhyMay 29 2023, 5:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd99f525fc5ff: [CommCoreModule] implement report store operations.

Revision Contents
Changeset List

PathSize
lib/
ops/
10 lines
native/
cpp/
CommonCpp/
NativeModules/
3 lines
77 lines
57 lines
_generated/
schema/
4 lines

Diff 26848

View Options

lib/ops/report-store-ops.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/ReportStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...