Details

Reviewers

tomek
michal

Commits

rCOMM2a202a6053d1: [lib] extract local id field before sending report

Summary

This field is needed only on client, also by this we're making sure that request validation on server will not fail.

Depends on D7909

Test Plan

Attach id field to report and try sending this and see if it's properly validated on keyserver.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 22 2023, 1:37 PM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 1:37 PM

kamil added a child revision: D7912: [lib] add local id field to existing reports.May 22 2023, 1:41 PM

Harbormaster completed remote builds in B19592: Diff 26777.May 22 2023, 1:54 PM

kamil published this revision for review.May 23 2023, 8:36 AM

tomek accepted this revision.May 23 2023, 10:12 AM

tomek added inline comments.

lib/actions/report-actions.js
42–46 ↗	(On Diff #26777)	Using term `raw` might be confusing, as it has a special meaning in our codebase. How about `clientReport` vs `serverReport`?

This revision is now accepted and ready to land.May 23 2023, 10:12 AM

rename variable

lib/actions/report-actions.js
42–46 ↗	(On Diff #26777)	fair point

move code directly to migration

Harbormaster completed remote builds in B19805: Diff 27119.May 29 2023, 9:03 AM

Harbormaster completed remote builds in B19806: Diff 27120.May 29 2023, 9:12 AM

fix committed code

Harbormaster completed remote builds in B19807: Diff 27121.May 29 2023, 9:34 AM

Closed by commit rCOMM2a202a6053d1: [lib] extract local id field before sending report. · Explain WhyMay 29 2023, 10:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2a202a6053d1: [lib] extract local id field before sending report.

kamil mentioned this in D9893: [Flow] improve report related types.Nov 15 2023, 12:07 PM

kamil mentioned this in rCOMMb9ee04633890: [Flow] improve report related types.Nov 15 2023, 1:21 PM

[lib] extract local id field before sending report
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 27126

lib/actions/report-actions.js

[lib] extract local id field before sending reportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27126

lib/actions/report-actions.js

[lib] extract local id field before sending report
ClosedPublic
Actions

Revision Contents
Changeset List