Page MenuHomePhabricator
Differential D7910

[lib] extract local id field before sending report
ClosedPublic
Actions

Authored by kamil on Mon, May 22, 6:37 AM.

Details

Reviewers
tomek
michal
Commits
rCOMM2a202a6053d1: [lib] extract local id field before sending report
Summary

This field is needed only on client, also by this we're making sure that request validation on server will not fail.

Depends on D7909

Test Plan

Attach id field to report and try sending this and see if it's properly validated on keyserver.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, May 22, 6:37 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMon, May 22, 6:37 AM
kamil added a child revision: D7912: [lib] add local id field to existing reports.Mon, May 22, 6:41 AM
Harbormaster completed remote builds in B19592: Diff 26777.Mon, May 22, 6:54 AM
kamil published this revision for review.Tue, May 23, 1:36 AM
tomek accepted this revision.Tue, May 23, 3:12 AM
tomek added inline comments.
lib/actions/report-actions.js
42–46 ↗(On Diff #26777)

Using term raw might be confusing, as it has a special meaning in our codebase. How about clientReport vs serverReport?

This revision is now accepted and ready to land.Tue, May 23, 3:12 AM
kamil updated this revision to Diff 27119.Mon, May 29, 1:46 AM

rename variable

lib/actions/report-actions.js
42–46 ↗(On Diff #26777)

fair point

kamil updated this revision to Diff 27120.Mon, May 29, 1:54 AM

move code directly to migration

Harbormaster completed remote builds in B19805: Diff 27119.Mon, May 29, 2:03 AM
Harbormaster completed remote builds in B19806: Diff 27120.Mon, May 29, 2:12 AM
kamil updated this revision to Diff 27121.Mon, May 29, 2:15 AM

fix committed code

Harbormaster completed remote builds in B19807: Diff 27121.Mon, May 29, 2:34 AM
Closed by commit rCOMM2a202a6053d1: [lib] extract local id field before sending report (authored by kamil). · Explain WhyMon, May 29, 3:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2a202a6053d1: [lib] extract local id field before sending report.

Revision Contents
Changeset List

PathSize
lib/
actions/
9 lines

Diff 27126

View Options

lib/actions/report-actions.js

Loading...