Page MenuHomePhabricator
Differential D7932

[lib] refactor adding reports action for using operations
ClosedPublic
Actions

Authored by kamil on Tue, May 23, 1:28 AM.

Details

Reviewers
tomek
michal
Commits
rCOMMef13f26aaca7: [lib] refactor adding reports action for using operations
Summary

Convert logic for ops approach.

Depends on D7931

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, May 23, 1:28 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptTue, May 23, 1:28 AM
kamil added a child revision: D7933: [lib] refactor handling new inconsistencies in report store reducer for using operations.Tue, May 23, 1:33 AM
Harbormaster completed remote builds in B19635: Diff 26843.Tue, May 23, 1:47 AM
kamil published this revision for review.Tue, May 23, 1:58 AM
kamil added inline comments.
lib/reducers/report-store-reducer.test.js
226–227 ↗(On Diff #26843)

now logic is based on ids - so modifying the test to use different ids for different objects

tomek accepted this revision.Wed, May 24, 3:01 AM
This revision is now accepted and ready to land.Wed, May 24, 3:01 AM
kamil updated this revision to Diff 27136.Mon, May 29, 3:49 AM

rebase

Harbormaster completed remote builds in B19817: Diff 27136.Mon, May 29, 4:07 AM
Closed by commit rCOMMef13f26aaca7: [lib] refactor adding reports action for using operations (authored by kamil). · Explain WhyMon, May 29, 4:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMef13f26aaca7: [lib] refactor adding reports action for using operations.

Revision Contents
Changeset List

PathSize
lib/
reducers/
15 lines

Diff 27144

View Options

lib/reducers/report-store-reducer.js

Loading...