[lib] refactor adding reports action for using operations
ClosedPublic
Actions

Authored by kamil on May 23 2023, 1:28 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMef13f26aaca7: [lib] refactor adding reports action for using operations

Summary

Convert logic for ops approach.

Depends on D7931

Test Plan

Tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 1:28 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 1:28 AM

kamil added a child revision: D7933: [lib] refactor handling new inconsistencies in report store reducer for using operations.May 23 2023, 1:33 AM

Harbormaster completed remote builds in B19635: Diff 26843.May 23 2023, 1:47 AM

kamil published this revision for review.May 23 2023, 1:58 AM

kamil added inline comments.

lib/reducers/report-store-reducer.test.js
226–227 ↗	(On Diff #26843)	now logic is based on `id`s - so modifying the test to use different ids for different objects

tomek accepted this revision.May 24 2023, 3:01 AM

This revision is now accepted and ready to land.May 24 2023, 3:01 AM

rebase

Harbormaster completed remote builds in B19817: Diff 27136.May 29 2023, 4:07 AM

Closed by commit rCOMMef13f26aaca7: [lib] refactor adding reports action for using operations (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMef13f26aaca7: [lib] refactor adding reports action for using operations.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

report-store-reducer.js

15 lines

Diff 27136

View Options

lib/reducers/report-store-reducer.js

[lib] refactor adding reports action for using operationsClosedPublicActions