[lib] add report store ops on JS side
ClosedPublic
Actions

Authored by kamil on Mon, May 22, 10:46 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM281a00b7b442: [lib] add report store ops on JS side

Summary

All operation types and function with processing those.

Depends on D7919

Test Plan

Run tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, May 22, 10:46 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMon, May 22, 10:46 AM

kamil added a child revision: D7921: [lib] refactor types to allow returning report store operations.Mon, May 22, 10:54 AM

Harbormaster completed remote builds in B19609: Diff 26802.Mon, May 22, 11:04 AM

kamil published this revision for review.Tue, May 23, 1:49 AM

tomek accepted this revision.Wed, May 24, 2:06 AM

tomek added inline comments.

lib/ops/report-store-ops.js
7 ↗	(On Diff #26802)	Should this be readonly?

This revision is now accepted and ready to land.Wed, May 24, 2:06 AM

make field read-only

lib/ops/report-store-ops.js
7 ↗	(On Diff #26802)	yes, fixing

Harbormaster completed remote builds in B19812: Diff 27131.Mon, May 29, 4:00 AM

Closed by commit rCOMM281a00b7b442: [lib] add report store ops on JS side (authored by kamil). · Explain WhyMon, May 29, 4:18 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM281a00b7b442: [lib] add report store ops on JS side.

Revision Contents
Changeset List

Path

Size

lib/

ops/

report-store-ops.js

49 lines

report-store-ops.test.js

180 lines

Diff 27140

View Options

lib/ops/report-store-ops.js