[native] start processing report store operations on database
ClosedPublic
Actions

Authored by kamil on May 23 2023, 10:28 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM3294c18298d0: [native] start processing report store operations on database

Summary

Enable running ops on SQLite.

Depends on D7936, D7933

Test Plan

Create some ops in reducer and check if they're properly processed on SQLite

Diff Detail

Repository

rCOMM Comm

Branch

reports-native

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 10:28 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 10:28 AM

kamil added a child revision: D7938: [native] fetch reports from SQLite and dispatch to store.May 23 2023, 10:44 AM

Harbormaster completed remote builds in B19649: Diff 26857.May 23 2023, 10:46 AM

kamil published this revision for review.May 23 2023, 11:55 PM

tomek accepted this revision.May 24 2023, 10:11 AM

tomek added inline comments.

lib/ops/report-store-ops.js
90	Should we e.g. throw when an unsupported operation appears?

This revision is now accepted and ready to land.May 24 2023, 10:11 AM

kamil edited parent revisions, added: D7977: [native] migrate reports to SQLite; removed: D7936: [CommCoreModule] implement getting report store from database.May 25 2023, 2:57 PM

rebase before landing

lib/ops/report-store-ops.js
90	In other cases we throw from C++ level, I'll follow current approach

kamil removed a parent revision: D7936: [CommCoreModule] implement getting report store from database.May 31 2023, 3:29 PM

Harbormaster completed remote builds in B19922: Diff 27297.May 31 2023, 3:48 PM

Closed by commit rCOMM3294c18298d0: [native] start processing report store operations on database. · Explain WhyMay 31 2023, 4:24 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3294c18298d0: [native] start processing report store operations on database.

Revision Contents
Changeset List

Path

Size

lib/

ops/

report-store-ops.js

21 lines

native/

redux/

redux-setup.js

3 lines

redux-utils.js

13 lines

Diff 26857

View Options

lib/ops/report-store-ops.js

View Options

native/redux/redux-setup.js

View Options

native/redux/redux-utils.js

[native] start processing report store operations on databaseClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26857

lib/ops/report-store-ops.js

native/redux/redux-setup.js

native/redux/redux-utils.js

[native] start processing report store operations on database
ClosedPublic
Actions

Revision Contents
Changeset List