Page MenuHomePhabricator

[web-db] implement SQL queries for report store
ClosedPublic

Authored by kamil on May 25 2023, 10:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 7:07 PM
Unknown Object (File)
Fri, Jun 14, 8:14 PM
Unknown Object (File)
Fri, Jun 14, 2:08 PM
Unknown Object (File)
Fri, Jun 14, 4:25 AM
Unknown Object (File)
Thu, Jun 13, 9:41 PM
Unknown Object (File)
Wed, Jun 12, 8:12 AM
Unknown Object (File)
Mon, Jun 3, 7:45 PM
Unknown Object (File)
Mon, Jun 3, 7:45 PM
Subscribers

Details

Summary

Mapping native structure and logic

Depends on D7982

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 25 2023, 1:46 PM
michal added inline comments.
web/database/queries/report-queries.test.js
25

Shouldn't we setupSQLiteDB in the beforeAll?

76

I think you missed the name

This revision is now accepted and ready to land.May 30 2023, 8:26 AM

add missing name

web/database/queries/report-queries.test.js
25

because tests are concentrated on the reports table (created via createReportTable()) it doesn't really make any difference, I'll remove this

76

oversight, fixing