Paths

Table of Contentst

-
services/comm-services-lib/src/
-
comm-services-lib/
-
src/
-
database.rs

[services-lib] Add DDB Attribute conversion traits
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 3:41 PM.

Details

Reviewers

michal
• jon
varun

Commits

rCOMM469bf6c19671: [services-lib] Add DDB Attribute conversion traits

Summary

Introduced traits that allow for implementing convenient conversions from DDB AttributeValue to various types.
They will be implemented in subsequent diffs.

Depends on D8787

Test Plan

Following bash one-liner:

cd services
for r in "comm-services-lib" "backup" "blob" "feature-flags"; do pushd $r; cargo check --all-features; popd; done

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 10 2023, 3:41 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 3:41 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8790: [services-lib] Implement DDB Attr conversions, deprecate old methods.Aug 10 2023, 3:44 PM

Harbormaster completed remote builds in B21707: Diff 29832.Aug 10 2023, 4:00 PM

bartek published this revision for review.Aug 11 2023, 2:23 AM

bartek added a reviewer: varun.

michal accepted this revision.Aug 11 2023, 4:13 AM

michal added inline comments.

services/comm-services-lib/src/database.rs
90 ↗	(On Diff #29832)	nit

This revision is now accepted and ready to land.Aug 11 2023, 4:13 AM

Fix typo

Harbormaster completed remote builds in B21794: Diff 29949.Aug 16 2023, 7:08 AM

Closed by commit rCOMM469bf6c19671: [services-lib] Add DDB Attribute conversion traits (authored by bartek). · Explain WhyAug 16 2023, 7:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM469bf6c19671: [services-lib] Add DDB Attribute conversion traits.

bartek mentioned this in D8850: [blob][feature-flags] Replace deprecated methods.Aug 17 2023, 9:08 AM

bartek mentioned this in rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods.Aug 22 2023, 12:17 AM

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

database.rs

35 lines

Diff 29949

View Options

services/comm-services-lib/src/database.rs

Show First 20 Lines • Show All 342 Lines • ▼ Show 20 Lines	query.append(SQL`
ORDER BY tw.threadID, tw.time DESC, tw.id DESC		ORDER BY tw.threadID, tw.time DESC, tw.id DESC
`);		`);

const [result] = await dbQuery(query);		const [result] = await dbQuery(query);
const derivedMessages = await fetchDerivedMessages(result, viewer);		const derivedMessages = await fetchDerivedMessages(result, viewer);
const messages = await parseMessageSQLResult(result, derivedMessages, viewer);		const messages = await parseMessageSQLResult(result, derivedMessages, viewer);

const rawMessageInfos = [];		const rawMessageInfos = [];
const threadToMessageCount = new Map();		const threadToMessageCount = new Map<string, number>();
for (const message of messages) {		for (const message of messages) {
const { rawMessageInfo } = message;		const { rawMessageInfo } = message;
rawMessageInfos.push(rawMessageInfo);		rawMessageInfos.push(rawMessageInfo);
const { threadID } = rawMessageInfo;		const { threadID } = rawMessageInfo;
const currentCountValue = threadToMessageCount.get(threadID);		const currentCountValue = threadToMessageCount.get(threadID);
const currentCount = currentCountValue ? currentCountValue : 0;		const currentCount = currentCountValue ? currentCountValue : 0;
threadToMessageCount.set(threadID, currentCount + 1);		threadToMessageCount.set(threadID, currentCount + 1);
}		}
▲ Show 20 Lines • Show All 479 Lines • ▼ Show 20 Lines	SELECT m.id, (
ORDER BY time DESC, id DESC		ORDER BY time DESC, id DESC
LIMIT 1		LIMIT 1
) content		) content
FROM messages m		FROM messages m
WHERE m.id IN(${messageIDs})		WHERE m.id IN(${messageIDs})
`;		`;

const [result] = await dbQuery(latestEditedMessageQuery);		const [result] = await dbQuery(latestEditedMessageQuery);
const latestContentByID = new Map();		const latestContentByID = new Map<string, EditMessageContent>();
for (const row of result) {		for (const row of result) {
if (!row.content) {		if (!row.content) {
continue;		continue;
}		}
const content = JSON.parse(row.content);		const content = JSON.parse(row.content);
latestContentByID.set(row.id.toString(), content);		latestContentByID.set(row.id.toString(), content);
}		}

▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines

[services-lib] Add DDB Attribute conversion traitsClosedPublicActions