Details
- Reviewers
bartek kamil • patryk • jon - Commits
- rCOMM3e386a6483a4: [backup] Use blob client
Add logging in main and check if url was set correctly when running
cargo run
cargo run -- --blob-service-url localhost:123
Check if it fails when running
cargo run -- --blob-service-url localhost:123asd
Try sending some data using blob client and check if it worked
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/src/config.rs | ||
|---|---|---|
| 18–19 ↗ | (On Diff #30129) | Clap will handle conversion for reqwest::Url for us so we don't have to do it during "runtime". We can also use default_value instead of default_value_t so the default url is parsed. |
| services/backup/src/constants.rs | ||
|---|---|---|
| 35 | I'm using the same address for tunnelbroker's websocket, do you mind doing another? | |
| services/backup/src/config.rs | ||
|---|---|---|
| 18–19 ↗ | (On Diff #30129) | That's a clever trick, stealing for reports service 😜 |
| services/backup/src/constants.rs | ||
|---|---|---|
| 35 | Yep, blob is currently using this for HTTP but I'm going to change it back to 50053 once I remove gRPC which is currently blocking that port. A workaround for now is to do pub const DEFAULT_BLOB_SERVICE_URL: &str = "http://localhost:50053"; and run blob locally with --http-port 50053 until I do the above | |