Page MenuHomePhabricator
Differential D8942

[reports-service] Introduce database client
ClosedPublic
Actions

Authored by bartek on Aug 25 2023, 3:10 AM.
Tags
None
Referenced Files
F3342136: D8942.diff
Fri, Nov 22, 12:38 AM
Unknown Object (File)
Fri, Nov 8, 5:07 AM
Unknown Object (File)
Sun, Oct 27, 3:48 PM
Unknown Object (File)
Sun, Oct 27, 3:48 PM
Unknown Object (File)
Sun, Oct 27, 3:48 PM
Unknown Object (File)
Sun, Oct 27, 3:48 PM
Unknown Object (File)
Sun, Oct 27, 3:42 PM
Unknown Object (File)
Oct 11 2024, 10:53 AM
View All 77 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• patryk
• jon
Commits
rCOMMc31b15da92b3: [reports-service] Introduce database client
Summary

Similiar to other services, created a struct representing DynamoDB client.
Created basic interfaces to store and retrieve reports. They're very simple but sufficient for now.

Depends on D8939, D8895

Test Plan

Storing reports was tested in D8895, other methods are tested together with HTTP interface (later in the stack)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 25 2023, 3:10 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptAug 25 2023, 3:10 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B22078: Diff 30306.Aug 25 2023, 3:28 AM
bartek published this revision for review.Aug 25 2023, 4:21 AM
• jon accepted this revision.Aug 25 2023, 4:37 PM
• jon added inline comments.
services/reports/src/database/client.rs
58 ↗(On Diff #30306)

should this go in constants?

102 ↗(On Diff #30306)

Potentially avoid forcing a Vec construction here if we take IntoIter<ReportItem>. But feel strongly about it, as DDB deals with Vec directly.

This revision is now accepted and ready to land.Aug 25 2023, 4:37 PM
bartek added inline comments.Aug 26 2023, 6:47 AM
services/reports/src/database/client.rs
102 ↗(On Diff #30306)

Good point

bartek updated this revision to Diff 30357.Aug 26 2023, 7:57 AM

Address feedback

Harbormaster completed remote builds in B22123: Diff 30357.Aug 26 2023, 8:15 AM
bartek added a child revision: D8970: [reports-service] Endpoint for uploading reports.Aug 28 2023, 7:01 AM
Closed by commit rCOMMc31b15da92b3: [reports-service] Introduce database client (authored by bartek). · Explain WhyAug 29 2023, 8:04 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMc31b15da92b3: [reports-service] Introduce database client.

Revision Contents
Changeset List

PathSize
services/
reports/
src/
1 line
database/
126 lines
1 line
1 line

Diff 30357

View Options

services/reports/src/constants.rs

Loading...
View Options

services/reports/src/database/client.rs

Loading...
View Options

services/reports/src/database/mod.rs

Loading...
View Options

services/reports/src/main.rs

Loading...