Page MenuHomePhabricator
Differential D6994

[web-db] implement types for `SubtleCrypto` module
ClosedPublic
Actions

Authored by kamil on Mar 7 2023, 9:31 AM.
Tags
None
Referenced Files
F1705749: D6994.id23664.diff
Sun, May 5, 6:46 PM
Unknown Object (File)
Sat, May 4, 12:02 AM
Unknown Object (File)
Sat, May 4, 12:02 AM
Unknown Object (File)
Fri, May 3, 11:59 PM
Unknown Object (File)
Fri, May 3, 6:40 PM
Unknown Object (File)
Fri, May 3, 2:53 PM
Unknown Object (File)
Fri, May 3, 1:21 PM
Unknown Object (File)
Mon, Apr 29, 9:02 AM
View All 63 Files
Subscribers
ashoat
atul
bartek

Details

Reviewers
michal
tomek
bartek
ashoat
Commits
rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module
Summary

There are no build in flow types for SubtleCrypto or any implementation we can use.

Adding types based on API docs and typescript.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
db-on-web-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mar 7 2023, 9:31 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 9:31 AM
kamil added a child revision: D6995: [web-db] implement crypto functions.Mar 7 2023, 9:35 AM
Harbormaster completed remote builds in B17170: Diff 23512.Mar 7 2023, 9:47 AM
kamil published this revision for review.Mar 7 2023, 10:08 AM
ashoat added inline comments.Mar 7 2023, 4:32 PM
web/database/utils/crypto-types.js
138–263

Why aren't these ones read-only?

268–269

Why aren't these ones read-only?

michal added inline comments.Mar 8 2023, 4:49 AM
web/database/utils/crypto-types.js
4

Can this be read-only?

bartek mentioned this in D7023: [web] Add Flow types for WebCrypto / SubtleCrypto.Mar 9 2023, 11:39 AM
kamil updated this revision to Diff 23601.Mar 10 2023, 7:04 AM

improve types and move to flow-typed

kamil added reviewers: bartek, ashoat.Mar 10 2023, 7:11 AM
kamil added a subscriber: bartek.

Previous types were too general (string instead of current algorithm names). I've updated this to be more precise (like D7023) but with specific types for the entire module - not only AES algorithms.

Checked if it works with D7024 (cc. @bartek).

Harbormaster completed remote builds in B17231: Diff 23601.Mar 10 2023, 7:20 AM
ashoat accepted this revision.Mar 10 2023, 10:51 AM
bartek accepted this revision.Mar 12 2023, 11:48 PM

LGTM, Works with my changes. Thank you for taking care of this!

This revision is now accepted and ready to land.Mar 12 2023, 11:48 PM
bartek added a child revision: D7024: [web] Implement AES encryption functions.Mar 12 2023, 11:49 PM
Closed by commit rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module (authored by kamil). · Explain WhyMar 13 2023, 1:13 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module.
kamil mentioned this in D8470: [web] rename WebCrypto to match convention.Jul 11 2023, 4:14 AM
kamil mentioned this in rCOMMfa7c84c9347a: [web] rename WebCrypto to match convention.Jul 12 2023, 6:07 AM

Revision Contents
Changeset List

PathSize
web/
database/
utils/
293 lines
utils/
7 lines

Diff 23512

View Options

web/database/utils/crypto-types.js

Loading...
View Options

web/utils/text-utils.js

Loading...