Page MenuHomePhabricator

[web] Add unit tests for AES functions
ClosedPublic

Authored by bartek on Mar 9 2023, 11:23 AM.
Tags
None
Referenced Files
F3353294: D7025.id23862.diff
Sat, Nov 23, 9:15 AM
F3353293: D7025.id23588.diff
Sat, Nov 23, 9:15 AM
F3352427: D7025.diff
Sat, Nov 23, 5:52 AM
Unknown Object (File)
Sun, Nov 3, 5:16 PM
Unknown Object (File)
Sat, Nov 2, 2:54 AM
Unknown Object (File)
Sat, Nov 2, 12:29 AM
Unknown Object (File)
Sat, Nov 2, 12:29 AM
Unknown Object (File)
Sat, Nov 2, 12:29 AM
Subscribers

Details

Summary

Added unit tests for functions implemented in D7024

Depends on D7024
Depends on D7019

Test Plan

Ran these tests

Diff Detail

Repository
rCOMM Comm
Branch
barthap/aes-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Mar 9 2023, 11:11 PM

I'll add a test for the correct key, but the malformed ciphertext

Thanks for including these tests!

web/media/aes-crypto-utils.test.js
61–63 ↗(On Diff #23676)

Appreciate the comments explaining what you're doing with the bitwise operators

This revision is now accepted and ready to land.Mar 13 2023, 4:45 PM
This revision was automatically updated to reflect the committed changes.