[web-db] implement Draft Store Operations
ClosedPublic
Actions

Authored by kamil on Mar 21 2023, 8:19 AM.

Details

Reviewers

Commits

rCOMM640ebb7a374d: [web-db] implement Draft Store Operations

Summary

SQL implementation of draft store operations.

Depends on D7121

Test Plan

Tests D7124

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

web/database/queries/draft-queries.js
3 ↗	(On Diff #23931)	native version: link
7 ↗	(On Diff #23931)	native version: link
20 ↗	(On Diff #23931)	native version: link Return value is not used anywhere so skipping it

kamil edited the test plan for this revision. (Show Details)Mar 21 2023, 8:24 AM

kamil published this revision for review.Mar 22 2023, 5:34 AM

ashoat added inline comments.

web/database/queries/draft-queries.js
4 ↗	(On Diff #23931)
9 ↗	(On Diff #23931)	Does this actually work in SQLite? In MySQL it would error because `key` is a reserved keyword

This revision is now accepted and ready to land.Mar 22 2023, 11:36 AM

add import, improve query format

web/database/queries/draft-queries.js
9 ↗	(On Diff #23931)	It works, I checked in D7124. It's the same engine as on native, since it works there it should work here. As far as I know, `KEY` is reserved in SQLite, not `key` (for `KEY` it fails).