Differential D7185

[web-db] process redux-persist operations in SQLite
ClosedPublic
Actions

Authored by kamil on Mar 27 2023, 4:48 AM.

Tags

None

Referenced Files

	F3352949: D7185.id24375.diff
	Sat, Nov 23, 7:27 AM

	Unknown Object (File)
	Fri, Nov 8, 12:37 PM

	Unknown Object (File)
	Fri, Nov 8, 10:59 AM

	Unknown Object (File)
	Fri, Nov 8, 7:40 AM

	Unknown Object (File)
	Fri, Nov 8, 3:15 AM

	Unknown Object (File)
	Wed, Nov 6, 3:19 AM

	Unknown Object (File)
	Wed, Nov 6, 3:19 AM

	Unknown Object (File)
	Wed, Nov 6, 3:19 AM

Subscribers

Details

Reviewers

michal
tomek
marcin

Commits

rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite

Summary

Processing operations for custom storage-engine

Depends on D7184

Test Plan

N/A

Diff Detail

Repository

Branch

db-web-7

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 27 2023, 4:48 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 27 2023, 4:48 AM

kamil mentioned this in D7182: [web-db] implement setting/getting `currentUserID` on worker.Mar 27 2023, 4:49 AM

kamil mentioned this in D7186: [web-db] start persisting SQLite content.Mar 27 2023, 4:55 AM

kamil added a child revision: D7186: [web-db] start persisting SQLite content.Mar 27 2023, 4:57 AM

Harbormaster completed remote builds in B17659: Diff 24166.Mar 27 2023, 5:03 AM

kamil published this revision for review.Mar 27 2023, 5:06 AM

It seems like this diff does some moving/refactoring and also introduces some new stuff, which makes it hard to review. More context: https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314?pvs=4

separate code for two diffs

kamil added a child revision: D7248: [web-db] clean-up processing app requests on worker.Mar 30 2023, 2:22 AM

kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Mar 30 2023, 2:24 AM

kamil added inline comments.

web/database/worker/db-worker.js
177 ↗	(On Diff #24375)	This code does not look good but it's addressed in D7248

Harbormaster completed remote builds in B17809: Diff 24375.Mar 30 2023, 2:37 AM

tomek accepted this revision.Mar 30 2023, 3:24 AM

This revision is now accepted and ready to land.Mar 30 2023, 3:24 AM

Closed by commit rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite (authored by kamil). · Explain WhyMar 31 2023, 2:15 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite.

kamil added a child revision: D7186: [web-db] start persisting SQLite content.Mar 31 2023, 2:36 AM

kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Mar 31 2023, 2:37 AM

kamil added a child revision: D7186: [web-db] start persisting SQLite content.Apr 3 2023, 2:11 AM

kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Apr 3 2023, 2:12 AM

Revision Contents
Changeset List

Path

Size

web/

database/

worker/

69 lines

types/

worker-types.js

33 lines

Diff 24166

web/database/worker/db-worker.js

Loading...

web/types/worker-types.js

Loading...