This is probably not necessary as I don't think that anyone has some persisted, not sent reports, but adding this for clarity.
Depends on D7910
Details
Details
- Reviewers
tomek michal - Commits
- rCOMM714c8bfce7c0: [lib] add local id field to existing reports
Make sure that there are some reports in store (e.g. throw in keyserver endpoint and create some inconsistencies). Then verify that id was added.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/report-utils.js | ||
|---|---|---|
| 30–37 | this function will be re-used in next diff | |
| lib/utils/report-utils.js | ||
|---|---|---|
| 35 | Should we do this only for reports which don't have the id? I guess in the migration it doesn't matter, but maybe for other usages of this function will? | |
| lib/utils/report-utils.js | ||
|---|---|---|
| 35 | it turned out that this was a bad assumption - this function will not be used in more places. Also, because id will be mandatory function argument type is not proper - I'll put this code directly into migration. | |