Page MenuHomePhabricator
Differential D7936

[CommCoreModule] implement getting report store from database
ClosedPublic
Actions

Authored by kamil on May 23 2023, 3:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:57 PM
Unknown Object (File)
Sun, Dec 15, 11:49 PM
Unknown Object (File)
Wed, Dec 4, 3:43 PM
Unknown Object (File)
Thu, Nov 28, 8:11 PM
View All 88 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM716822a273ea: [CommCoreModule] implement getting report store from database
Summary

Following the same approach as for different stores

Depends on D7934

Test Plan

Check if data is properly fetched from database

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 3:08 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 3:08 AM
Harbormaster completed remote builds in B19646: Diff 26854.May 23 2023, 3:26 AM
kamil added a child revision: D7937: [native] start processing report store operations on database.May 23 2023, 3:28 AM
kamil updated this revision to Diff 26919.May 23 2023, 4:33 PM

minor fixes

Harbormaster completed remote builds in B19706: Diff 26919.May 23 2023, 4:50 PM
kamil published this revision for review.May 23 2023, 4:55 PM
tomek accepted this revision.May 24 2023, 2:01 AM
This revision is now accepted and ready to land.May 24 2023, 2:01 AM
kamil added a child revision: D7975: [CommCoreModule] implement synchronous report store operations.May 25 2023, 7:26 AM
kamil removed a child revision: D7937: [native] start processing report store operations on database.May 25 2023, 7:57 AM
kamil mentioned this in D8008: [CommCoreModule] add table and methods for report store.May 29 2023, 4:30 AM
kamil updated this revision to Diff 27149.May 29 2023, 4:44 AM

rebase

Harbormaster completed remote builds in B19822: Diff 27149.May 29 2023, 5:02 AM
Closed by commit rCOMM716822a273ea: [CommCoreModule] implement getting report store from database (authored by kamil). · Explain WhyMay 29 2023, 5:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM716822a273ea: [CommCoreModule] implement getting report store from database.
kamil added a child revision: D7937: [native] start processing report store operations on database.May 31 2023, 8:28 AM
kamil removed a child revision: D7937: [native] start processing report store operations on database.May 31 2023, 8:29 AM

Revision Contents
Changeset List

PathSize
lib/
ops/
4 lines
types/
6 lines
native/
cpp/
CommonCpp/
NativeModules/
25 lines
web/
database/
worker/
1 line

Diff 26919

View Options

lib/ops/report-store-ops.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

web/database/worker/db-worker.js

Loading...