[lib] add local is field to reports
ClosedPublic
Actions

Authored by kamil on May 22 2023, 1:32 PM.

Details

Reviewers

tomek
michal

Commits

rCOMM1fd195c04737: [lib] add local is field to reports

Summary

Those ids will help with moving reports to SQLite - we will not have to compare entire objects, only ids.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

land-rs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 22 2023, 1:32 PM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 1:32 PM

kamil added a child revision: D7910: [lib] extract local id field before sending report.May 22 2023, 1:37 PM

Harbormaster completed remote builds in B19591: Diff 26776.May 22 2023, 1:51 PM

kamil published this revision for review.May 23 2023, 8:35 AM

tomek accepted this revision.May 23 2023, 10:00 AM

tomek added inline comments.

lib/types/report-types.js
109 ↗	(On Diff #26776)	Why this is optional?

This revision is now accepted and ready to land.May 23 2023, 10:00 AM

rebase

kamil added inline comments.May 29 2023, 8:46 AM

lib/types/report-types.js
109 ↗	(On Diff #26776)	To make id logically correct, adding this as optional, in next diffs making sure that this field will not have to be optional, and then updating this in D7916.

Harbormaster completed remote builds in B19804: Diff 27118.May 29 2023, 8:59 AM

Closed by commit rCOMM1fd195c04737: [lib] add local is field to reports. · Explain WhyMay 29 2023, 10:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1fd195c04737: [lib] add local is field to reports.

ashoat mentioned this in D9863: [Flow202][keyserver][skip-ci] [14/x] Address type errors with report-responders.js.Nov 14 2023, 2:01 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

report-types.js

5 lines

Diff 27118

View Options

[lib] add local is field to reportsClosedPublicActions