Page MenuHomePhabricator
Differential D7920

[lib] add report store ops on JS side
ClosedPublic
Actions

Authored by kamil on May 22 2023, 10:46 AM.
Tags
None
Referenced Files
F6236148: D7920.diff
Thu, Apr 24, 3:07 PM
Unknown Object (File)
Fri, Apr 18, 11:42 PM
Unknown Object (File)
Fri, Apr 18, 7:05 AM
Unknown Object (File)
Fri, Apr 18, 6:05 AM
Unknown Object (File)
Fri, Apr 18, 1:37 AM
Unknown Object (File)
Thu, Apr 17, 10:58 AM
Unknown Object (File)
Tue, Apr 1, 1:47 PM
Unknown Object (File)
Mar 23 2025, 1:55 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM281a00b7b442: [lib] add report store ops on JS side
Summary

All operation types and function with processing those.

Depends on D7919

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 22 2023, 10:46 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 10:46 AM
kamil added a child revision: D7921: [lib] refactor types to allow returning report store operations.May 22 2023, 10:54 AM
Harbormaster completed remote builds in B19609: Diff 26802.May 22 2023, 11:04 AM
kamil published this revision for review.May 23 2023, 1:49 AM
tomek accepted this revision.May 24 2023, 2:06 AM
tomek added inline comments.
lib/ops/report-store-ops.js
7 ↗(On Diff #26802)

Should this be readonly?

This revision is now accepted and ready to land.May 24 2023, 2:06 AM
kamil updated this revision to Diff 27131.May 29 2023, 3:42 AM

make field read-only

lib/ops/report-store-ops.js
7 ↗(On Diff #26802)

yes, fixing

Harbormaster completed remote builds in B19812: Diff 27131.May 29 2023, 4:00 AM
Closed by commit rCOMM281a00b7b442: [lib] add report store ops on JS side (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM281a00b7b442: [lib] add report store ops on JS side.

Revision Contents
Changeset List

PathSize
lib/
ops/
49 lines
180 lines

Diff 27131

View Options

lib/ops/report-store-ops.js

Show All 11 Lines
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { createObjectSelector } from 'reselect-map'; import { createObjectSelector } from 'reselect-map';
import { import {
filteredThreadIDsSelector, filteredThreadIDsSelector,
includeDeletedSelector, includeDeletedSelector,
} from './calendar-filter-selectors.js'; } from './calendar-filter-selectors.js';
import { relativeMemberInfoSelectorForMembersOfThread } from './user-selectors.js'; import { relativeMemberInfoSelectorForMembersOfThread } from './user-selectors.js';
import {
getAvatarForThread,
getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js';
import { createEntryInfo } from '../shared/entry-utils.js'; import { createEntryInfo } from '../shared/entry-utils.js';
import { getMostRecentNonLocalMessageID } from '../shared/message-utils.js'; import { getMostRecentNonLocalMessageID } from '../shared/message-utils.js';
import { import {
threadInHomeChatList, threadInHomeChatList,
threadInBackgroundChatList, threadInBackgroundChatList,
threadInFilterList, threadInFilterList,
threadInfoFromRawThreadInfo, threadInfoFromRawThreadInfo,
threadHasPermission, threadHasPermission,
threadInChatList, threadInChatList,
threadHasAdminRole, threadHasAdminRole,
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { import {
type ThreadInfo, type ThreadInfo,
type RawThreadInfo, type RawThreadInfo,
type RelativeMemberInfo, type RelativeMemberInfo,
threadPermissions, threadPermissions,
▲ Show 20 Lines • Show All 364 Lines • ▼ Show 20 Lines for (const threadID in rawThreadInfos) {
) { ) {
result.set(pendingThreadID, threadID); result.set(pendingThreadID, threadID);
} }
} }
return result; return result;
}, },
); );
const baseSavedEmojiAvatarSelectorForThread = (
threadID: string,
containingThreadID: ?string,
) =>
createSelector(
(state: BaseAppState<*>) => threadInfoSelector(state)[threadID],
(state: BaseAppState<*>) =>
containingThreadID ? threadInfoSelector(state)[containingThreadID] : null,
(threadInfo: ThreadInfo, containingThreadInfo: ?ThreadInfo) => {
return () => {
let threadAvatar = getAvatarForThread(threadInfo, containingThreadInfo);
if (threadAvatar.type !== 'emoji') {
threadAvatar = getRandomDefaultEmojiAvatar();
}
return threadAvatar;
};
},
);
const savedEmojiAvatarSelectorForThread: (
threadID: string,
containingThreadID: ?string,
) => (state: BaseAppState<*>) => () => ClientEmojiAvatar = _memoize(
baseSavedEmojiAvatarSelectorForThread,
);
export { export {
ancestorThreadInfos, ancestorThreadInfos,
threadInfoSelector, threadInfoSelector,
communityThreadSelector, communityThreadSelector,
onScreenThreadInfos, onScreenThreadInfos,
onScreenEntryEditableThreadInfos, onScreenEntryEditableThreadInfos,
entryInfoSelector, entryInfoSelector,
currentDaysToEntries, currentDaysToEntries,
childThreadInfos, childThreadInfos,
unreadCount, unreadCount,
unreadBackgroundCount, unreadBackgroundCount,
otherUsersButNoOtherAdmins, otherUsersButNoOtherAdmins,
mostRecentlyReadThread, mostRecentlyReadThread,
mostRecentlyReadThreadSelector, mostRecentlyReadThreadSelector,
sidebarInfoSelector, sidebarInfoSelector,
threadInfoFromSourceMessageIDSelector, threadInfoFromSourceMessageIDSelector,
pendingToRealizedThreadIDsSelector, pendingToRealizedThreadIDsSelector,
savedEmojiAvatarSelectorForThread,
}; };
View Options

lib/ops/report-store-ops.test.js

Show All 11 Lines
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { createObjectSelector } from 'reselect-map'; import { createObjectSelector } from 'reselect-map';
import { import {
filteredThreadIDsSelector, filteredThreadIDsSelector,
includeDeletedSelector, includeDeletedSelector,
} from './calendar-filter-selectors.js'; } from './calendar-filter-selectors.js';
import { relativeMemberInfoSelectorForMembersOfThread } from './user-selectors.js'; import { relativeMemberInfoSelectorForMembersOfThread } from './user-selectors.js';
import {
getAvatarForThread,
getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js';
import { createEntryInfo } from '../shared/entry-utils.js'; import { createEntryInfo } from '../shared/entry-utils.js';
import { getMostRecentNonLocalMessageID } from '../shared/message-utils.js'; import { getMostRecentNonLocalMessageID } from '../shared/message-utils.js';
import { import {
threadInHomeChatList, threadInHomeChatList,
threadInBackgroundChatList, threadInBackgroundChatList,
threadInFilterList, threadInFilterList,
threadInfoFromRawThreadInfo, threadInfoFromRawThreadInfo,
threadHasPermission, threadHasPermission,
threadInChatList, threadInChatList,
threadHasAdminRole, threadHasAdminRole,
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { import {
type ThreadInfo, type ThreadInfo,
type RawThreadInfo, type RawThreadInfo,
type RelativeMemberInfo, type RelativeMemberInfo,
threadPermissions, threadPermissions,
▲ Show 20 Lines • Show All 364 Lines • ▼ Show 20 Lines for (const threadID in rawThreadInfos) {
) { ) {
result.set(pendingThreadID, threadID); result.set(pendingThreadID, threadID);
} }
} }
return result; return result;
}, },
); );
const baseSavedEmojiAvatarSelectorForThread = (
threadID: string,
containingThreadID: ?string,
) =>
createSelector(
(state: BaseAppState<*>) => threadInfoSelector(state)[threadID],
(state: BaseAppState<*>) =>
containingThreadID ? threadInfoSelector(state)[containingThreadID] : null,
(threadInfo: ThreadInfo, containingThreadInfo: ?ThreadInfo) => {
return () => {
let threadAvatar = getAvatarForThread(threadInfo, containingThreadInfo);
if (threadAvatar.type !== 'emoji') {
threadAvatar = getRandomDefaultEmojiAvatar();
}
return threadAvatar;
};
},
);
const savedEmojiAvatarSelectorForThread: (
threadID: string,
containingThreadID: ?string,
) => (state: BaseAppState<*>) => () => ClientEmojiAvatar = _memoize(
baseSavedEmojiAvatarSelectorForThread,
);
export { export {
ancestorThreadInfos, ancestorThreadInfos,
threadInfoSelector, threadInfoSelector,
communityThreadSelector, communityThreadSelector,
onScreenThreadInfos, onScreenThreadInfos,
onScreenEntryEditableThreadInfos, onScreenEntryEditableThreadInfos,
entryInfoSelector, entryInfoSelector,
currentDaysToEntries, currentDaysToEntries,
childThreadInfos, childThreadInfos,
unreadCount, unreadCount,
unreadBackgroundCount, unreadBackgroundCount,
otherUsersButNoOtherAdmins, otherUsersButNoOtherAdmins,
mostRecentlyReadThread, mostRecentlyReadThread,
mostRecentlyReadThreadSelector, mostRecentlyReadThreadSelector,
sidebarInfoSelector, sidebarInfoSelector,
threadInfoFromSourceMessageIDSelector, threadInfoFromSourceMessageIDSelector,
pendingToRealizedThreadIDsSelector, pendingToRealizedThreadIDsSelector,
savedEmojiAvatarSelectorForThread,
}; };