Page MenuHomePhabricator
Differential D7938

[native] fetch reports from SQLite and dispatch to store
ClosedPublic
Actions

Authored by kamil on May 23 2023, 3:44 AM.
Tags
None
Referenced Files
F5563313: D7938.diff
Sat, Apr 12, 2:18 PM
Unknown Object (File)
Tue, Apr 1, 2:01 PM
Unknown Object (File)
Tue, Mar 18, 2:33 AM
Unknown Object (File)
Tue, Mar 18, 2:33 AM
Unknown Object (File)
Tue, Mar 18, 2:33 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:24 AM
Unknown Object (File)
Sat, Mar 15, 12:04 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM2cb7cef3cfe0: [native] fetch reports from SQLite and dispatch to store
Summary

Retrieving data and putting back to store.
We could consider moving this logic to different place - reports are not needed on app start.

Depends on D7937

Test Plan

Check if reports are properly fetched and converted.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 3:44 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 3:44 AM
kamil added a child revision: D7939: [native] stop persisting reports.May 23 2023, 4:00 AM
Harbormaster completed remote builds in B19650: Diff 26858.May 23 2023, 4:03 AM
kamil published this revision for review.May 23 2023, 4:55 PM
tomek accepted this revision.May 24 2023, 3:19 AM

We could consider moving this logic to different place - reports are not needed on app start.

Yeah, waiting for these when the app starts isn't ideal.

This revision is now accepted and ready to land.May 24 2023, 3:19 AM
kamil updated this revision to Diff 27298.May 31 2023, 8:32 AM

rebase before landing

kamil added a comment.May 31 2023, 8:33 AM
In D7938#235912, @tomek wrote:

We could consider moving this logic to different place - reports are not needed on app start.

Yeah, waiting for these when the app starts isn't ideal.

created task: ENG-4021

Harbormaster completed remote builds in B19923: Diff 27298.May 31 2023, 8:51 AM
Closed by commit rCOMM2cb7cef3cfe0: [native] fetch reports from SQLite and dispatch to store (authored by kamil). · Explain WhyMay 31 2023, 9:24 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2cb7cef3cfe0: [native] fetch reports from SQLite and dispatch to store.

Revision Contents
Changeset List

PathSize
lib/
ops/
7 lines
reducers/
1 line
25 lines
types/
2 lines
native/
data/
7 lines

Diff 27298

View Options

lib/ops/report-store-ops.js

// @flow // @flow
import urlParseLax from 'url-parse-lax'; import urlParseLax from 'url-parse-lax';
export type URLInfo = { export type URLInfo = {
year?: number, year?: number,
month?: number, // 1-indexed month?: number, // 1-indexed
verify?: string, verify?: string,
calendar?: boolean, calendar?: boolean,
chat?: boolean, chat?: boolean,
apps?: boolean,
thread?: string, thread?: string,
... ...
}; };
const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i'); const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i');
const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i'); const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i');
const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i'); const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i');
const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i'); const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i');
const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i'); const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i');
const chatRegex = new RegExp('(/|^)chat(/|$)', 'i'); const chatRegex = new RegExp('(/|^)chat(/|$)', 'i');
const appsRegex = new RegExp('(/|^)apps(/|$)', 'i');
function infoFromURL(url: string): URLInfo { function infoFromURL(url: string): URLInfo {
const yearMatches = yearRegex.exec(url); const yearMatches = yearRegex.exec(url);
const monthMatches = monthRegex.exec(url); const monthMatches = monthRegex.exec(url);
const threadMatches = threadRegex.exec(url); const threadMatches = threadRegex.exec(url);
const verifyMatches = verifyRegex.exec(url); const verifyMatches = verifyRegex.exec(url);
const calendarTest = calendarRegex.test(url); const calendarTest = calendarRegex.test(url);
const chatTest = chatRegex.test(url); const chatTest = chatRegex.test(url);
const appsTest = appsRegex.test(url);
const returnObj = {}; const returnObj = {};
if (yearMatches) { if (yearMatches) {
returnObj.year = parseInt(yearMatches[2], 10); returnObj.year = parseInt(yearMatches[2], 10);
} }
if (monthMatches) { if (monthMatches) {
const month = parseInt(monthMatches[2], 10); const month = parseInt(monthMatches[2], 10);
if (month < 1 || month > 12) { if (month < 1 || month > 12) {
throw new Error('invalid_month'); throw new Error('invalid_month');
} }
returnObj.month = month; returnObj.month = month;
} }
if (threadMatches) { if (threadMatches) {
returnObj.thread = threadMatches[2]; returnObj.thread = threadMatches[2];
} }
if (verifyMatches) { if (verifyMatches) {
returnObj.verify = verifyMatches[2]; returnObj.verify = verifyMatches[2];
} }
if (calendarTest) { if (calendarTest) {
returnObj.calendar = true; returnObj.calendar = true;
} else if (chatTest) { } else if (chatTest) {
returnObj.chat = true; returnObj.chat = true;
} else if (appsTest) {
returnObj.apps = true;
} }
return returnObj; return returnObj;
} }
function normalizeURL(url: string): string { function normalizeURL(url: string): string {
return urlParseLax(url).href; return urlParseLax(url).href;
} }
const setURLPrefix = 'SET_URL_PREFIX'; const setURLPrefix = 'SET_URL_PREFIX';
export { infoFromURL, normalizeURL, setURLPrefix }; export { infoFromURL, normalizeURL, setURLPrefix };
View Options

lib/reducers/message-reducer.test.js

// @flow // @flow
import urlParseLax from 'url-parse-lax'; import urlParseLax from 'url-parse-lax';
export type URLInfo = { export type URLInfo = {
year?: number, year?: number,
month?: number, // 1-indexed month?: number, // 1-indexed
verify?: string, verify?: string,
calendar?: boolean, calendar?: boolean,
chat?: boolean, chat?: boolean,
apps?: boolean,
thread?: string, thread?: string,
... ...
}; };
const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i'); const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i');
const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i'); const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i');
const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i'); const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i');
const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i'); const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i');
const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i'); const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i');
const chatRegex = new RegExp('(/|^)chat(/|$)', 'i'); const chatRegex = new RegExp('(/|^)chat(/|$)', 'i');
const appsRegex = new RegExp('(/|^)apps(/|$)', 'i');
function infoFromURL(url: string): URLInfo { function infoFromURL(url: string): URLInfo {
const yearMatches = yearRegex.exec(url); const yearMatches = yearRegex.exec(url);
const monthMatches = monthRegex.exec(url); const monthMatches = monthRegex.exec(url);
const threadMatches = threadRegex.exec(url); const threadMatches = threadRegex.exec(url);
const verifyMatches = verifyRegex.exec(url); const verifyMatches = verifyRegex.exec(url);
const calendarTest = calendarRegex.test(url); const calendarTest = calendarRegex.test(url);
const chatTest = chatRegex.test(url); const chatTest = chatRegex.test(url);
const appsTest = appsRegex.test(url);
const returnObj = {}; const returnObj = {};
if (yearMatches) { if (yearMatches) {
returnObj.year = parseInt(yearMatches[2], 10); returnObj.year = parseInt(yearMatches[2], 10);
} }
if (monthMatches) { if (monthMatches) {
const month = parseInt(monthMatches[2], 10); const month = parseInt(monthMatches[2], 10);
if (month < 1 || month > 12) { if (month < 1 || month > 12) {
throw new Error('invalid_month'); throw new Error('invalid_month');
} }
returnObj.month = month; returnObj.month = month;
} }
if (threadMatches) { if (threadMatches) {
returnObj.thread = threadMatches[2]; returnObj.thread = threadMatches[2];
} }
if (verifyMatches) { if (verifyMatches) {
returnObj.verify = verifyMatches[2]; returnObj.verify = verifyMatches[2];
} }
if (calendarTest) { if (calendarTest) {
returnObj.calendar = true; returnObj.calendar = true;
} else if (chatTest) { } else if (chatTest) {
returnObj.chat = true; returnObj.chat = true;
} else if (appsTest) {
returnObj.apps = true;
} }
return returnObj; return returnObj;
} }
function normalizeURL(url: string): string { function normalizeURL(url: string): string {
return urlParseLax(url).href; return urlParseLax(url).href;
} }
const setURLPrefix = 'SET_URL_PREFIX'; const setURLPrefix = 'SET_URL_PREFIX';
export { infoFromURL, normalizeURL, setURLPrefix }; export { infoFromURL, normalizeURL, setURLPrefix };
View Options

lib/reducers/report-store-reducer.js

// @flow // @flow
import urlParseLax from 'url-parse-lax'; import urlParseLax from 'url-parse-lax';
export type URLInfo = { export type URLInfo = {
year?: number, year?: number,
month?: number, // 1-indexed month?: number, // 1-indexed
verify?: string, verify?: string,
calendar?: boolean, calendar?: boolean,
chat?: boolean, chat?: boolean,
apps?: boolean,
thread?: string, thread?: string,
... ...
}; };
const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i'); const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i');
const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i'); const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i');
const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i'); const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i');
const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i'); const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i');
const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i'); const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i');
const chatRegex = new RegExp('(/|^)chat(/|$)', 'i'); const chatRegex = new RegExp('(/|^)chat(/|$)', 'i');
const appsRegex = new RegExp('(/|^)apps(/|$)', 'i');
function infoFromURL(url: string): URLInfo { function infoFromURL(url: string): URLInfo {
const yearMatches = yearRegex.exec(url); const yearMatches = yearRegex.exec(url);
const monthMatches = monthRegex.exec(url); const monthMatches = monthRegex.exec(url);
const threadMatches = threadRegex.exec(url); const threadMatches = threadRegex.exec(url);
const verifyMatches = verifyRegex.exec(url); const verifyMatches = verifyRegex.exec(url);
const calendarTest = calendarRegex.test(url); const calendarTest = calendarRegex.test(url);
const chatTest = chatRegex.test(url); const chatTest = chatRegex.test(url);
const appsTest = appsRegex.test(url);
const returnObj = {}; const returnObj = {};
if (yearMatches) { if (yearMatches) {
returnObj.year = parseInt(yearMatches[2], 10); returnObj.year = parseInt(yearMatches[2], 10);
} }
if (monthMatches) { if (monthMatches) {
const month = parseInt(monthMatches[2], 10); const month = parseInt(monthMatches[2], 10);
if (month < 1 || month > 12) { if (month < 1 || month > 12) {
throw new Error('invalid_month'); throw new Error('invalid_month');
} }
returnObj.month = month; returnObj.month = month;
} }
if (threadMatches) { if (threadMatches) {
returnObj.thread = threadMatches[2]; returnObj.thread = threadMatches[2];
} }
if (verifyMatches) { if (verifyMatches) {
returnObj.verify = verifyMatches[2]; returnObj.verify = verifyMatches[2];
} }
if (calendarTest) { if (calendarTest) {
returnObj.calendar = true; returnObj.calendar = true;
} else if (chatTest) { } else if (chatTest) {
returnObj.chat = true; returnObj.chat = true;
} else if (appsTest) {
returnObj.apps = true;
} }
return returnObj; return returnObj;
} }
function normalizeURL(url: string): string { function normalizeURL(url: string): string {
return urlParseLax(url).href; return urlParseLax(url).href;
} }
const setURLPrefix = 'SET_URL_PREFIX'; const setURLPrefix = 'SET_URL_PREFIX';
export { infoFromURL, normalizeURL, setURLPrefix }; export { infoFromURL, normalizeURL, setURLPrefix };
View Options

lib/types/redux-types.js

// @flow // @flow
import urlParseLax from 'url-parse-lax'; import urlParseLax from 'url-parse-lax';
export type URLInfo = { export type URLInfo = {
year?: number, year?: number,
month?: number, // 1-indexed month?: number, // 1-indexed
verify?: string, verify?: string,
calendar?: boolean, calendar?: boolean,
chat?: boolean, chat?: boolean,
apps?: boolean,
thread?: string, thread?: string,
... ...
}; };
const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i'); const yearRegex = new RegExp('(/|^)year/([0-9]+)(/|$)', 'i');
const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i'); const monthRegex = new RegExp('(/|^)month/([0-9]+)(/|$)', 'i');
const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i'); const threadRegex = new RegExp('(/|^)thread/([0-9]+)(/|$)', 'i');
const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i'); const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i');
const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i'); const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i');
const chatRegex = new RegExp('(/|^)chat(/|$)', 'i'); const chatRegex = new RegExp('(/|^)chat(/|$)', 'i');
const appsRegex = new RegExp('(/|^)apps(/|$)', 'i');
function infoFromURL(url: string): URLInfo { function infoFromURL(url: string): URLInfo {
const yearMatches = yearRegex.exec(url); const yearMatches = yearRegex.exec(url);
const monthMatches = monthRegex.exec(url); const monthMatches = monthRegex.exec(url);
const threadMatches = threadRegex.exec(url); const threadMatches = threadRegex.exec(url);
const verifyMatches = verifyRegex.exec(url); const verifyMatches = verifyRegex.exec(url);
const calendarTest = calendarRegex.test(url); const calendarTest = calendarRegex.test(url);
const chatTest = chatRegex.test(url); const chatTest = chatRegex.test(url);
const appsTest = appsRegex.test(url);
const returnObj = {}; const returnObj = {};
if (yearMatches) { if (yearMatches) {
returnObj.year = parseInt(yearMatches[2], 10); returnObj.year = parseInt(yearMatches[2], 10);
} }
if (monthMatches) { if (monthMatches) {
const month = parseInt(monthMatches[2], 10); const month = parseInt(monthMatches[2], 10);
if (month < 1 || month > 12) { if (month < 1 || month > 12) {
throw new Error('invalid_month'); throw new Error('invalid_month');
} }
returnObj.month = month; returnObj.month = month;
} }
if (threadMatches) { if (threadMatches) {
returnObj.thread = threadMatches[2]; returnObj.thread = threadMatches[2];
} }
if (verifyMatches) { if (verifyMatches) {
returnObj.verify = verifyMatches[2]; returnObj.verify = verifyMatches[2];
} }
if (calendarTest) { if (calendarTest) {
returnObj.calendar = true; returnObj.calendar = true;
} else if (chatTest) { } else if (chatTest) {
returnObj.chat = true; returnObj.chat = true;
} else if (appsTest) {
returnObj.apps = true;
} }
return returnObj; return returnObj;
} }
function normalizeURL(url: string): string { function normalizeURL(url: string): string {
return urlParseLax(url).href; return urlParseLax(url).href;
} }
const setURLPrefix = 'SET_URL_PREFIX'; const setURLPrefix = 'SET_URL_PREFIX';
export { infoFromURL, normalizeURL, setURLPrefix }; export { infoFromURL, normalizeURL, setURLPrefix };
View Options

native/data/sqlite-data-handler.js

Loading...