Page MenuHomePhabricator
Differential D8789

[services-lib] Add DDB Attribute conversion traits
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 3:41 PM.
Tags
None
Referenced Files
F3385541: D8789.id29949.diff
Fri, Nov 29, 12:57 AM
F3385431: D8789.id29832.diff
Fri, Nov 29, 12:20 AM
Unknown Object (File)
Mon, Nov 25, 6:55 PM
Unknown Object (File)
Sat, Nov 23, 11:46 PM
Unknown Object (File)
Sat, Nov 23, 4:33 AM
Unknown Object (File)
Fri, Nov 22, 4:38 AM
Unknown Object (File)
Mon, Nov 18, 2:08 PM
Unknown Object (File)
Tue, Nov 12, 12:09 PM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
varun
Commits
rCOMM469bf6c19671: [services-lib] Add DDB Attribute conversion traits
Summary

Introduced traits that allow for implementing convenient conversions from DDB AttributeValue to various types.
They will be implemented in subsequent diffs.

Depends on D8787

Test Plan

Following bash one-liner:

cd services
for r in "comm-services-lib" "backup" "blob" "feature-flags"; do pushd $r; cargo check --all-features; popd; done

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 10 2023, 3:41 PM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 3:41 PM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
bartek added a child revision: D8790: [services-lib] Implement DDB Attr conversions, deprecate old methods.Aug 10 2023, 3:44 PM
Harbormaster completed remote builds in B21707: Diff 29832.Aug 10 2023, 4:00 PM
bartek published this revision for review.Aug 11 2023, 2:23 AM
bartek added a reviewer: varun.
michal accepted this revision.Aug 11 2023, 4:13 AM
michal added inline comments.
services/comm-services-lib/src/database.rs
90

nit

This revision is now accepted and ready to land.Aug 11 2023, 4:13 AM
bartek updated this revision to Diff 29949.Aug 16 2023, 6:50 AM

Fix typo

Harbormaster completed remote builds in B21794: Diff 29949.Aug 16 2023, 7:08 AM
Closed by commit rCOMM469bf6c19671: [services-lib] Add DDB Attribute conversion traits (authored by bartek). · Explain WhyAug 16 2023, 7:25 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM469bf6c19671: [services-lib] Add DDB Attribute conversion traits.
bartek mentioned this in D8850: [blob][feature-flags] Replace deprecated methods.Aug 17 2023, 9:08 AM
bartek mentioned this in rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods.Aug 22 2023, 12:17 AM

Revision Contents
Changeset List

PathSize
services/
comm-services-lib/
src/
34 lines

Diff 29832

View Options

services/comm-services-lib/src/database.rs

Loading...