Page MenuHomePhabricator

[backup] Use blob client
ClosedPublic

Authored by michal on Aug 21 2023, 2:23 AM.
Tags
None
Referenced Files
F3382542: D8883.id30191.diff
Thu, Nov 28, 11:16 AM
F3382481: D8883.id30323.diff
Thu, Nov 28, 11:01 AM
F3382474: D8883.id30129.diff
Thu, Nov 28, 10:59 AM
F3382240: D8883.diff
Thu, Nov 28, 9:23 AM
Unknown Object (File)
Sun, Nov 24, 6:25 PM
Unknown Object (File)
Mon, Nov 4, 3:04 AM
Unknown Object (File)
Oct 27 2024, 3:48 PM
Unknown Object (File)
Oct 27 2024, 3:48 PM
Subscribers

Details

Summary

ENG-3687
Use new http blob client

Depends on D8882

Test Plan

Add logging in main and check if url was set correctly when running
cargo run
cargo run -- --blob-service-url localhost:123
Check if it fails when running
cargo run -- --blob-service-url localhost:123asd

Try sending some data using blob client and check if it worked

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

services/backup/src/config.rs
18–19

Clap will handle conversion for reqwest::Url for us so we don't have to do it during "runtime". We can also use default_value instead of default_value_t so the default url is parsed.

jon requested changes to this revision.Aug 21 2023, 7:43 PM
jon added inline comments.
services/backup/src/constants.rs
35 ↗(On Diff #30155)

I'm using the same address for tunnelbroker's websocket, do you mind doing another?

This revision now requires changes to proceed.Aug 21 2023, 7:43 PM
services/backup/src/config.rs
18–19

That's a clever trick, stealing for reports service 😜

services/backup/src/constants.rs
35 ↗(On Diff #30155)

That's the default from blob/src/constants.rs cc @bartek

bartek added inline comments.
services/backup/src/constants.rs
35 ↗(On Diff #30155)

Yep, blob is currently using this for HTTP but I'm going to change it back to 50053 once I remove gRPC which is currently blocking that port.

A workaround for now is to do pub const DEFAULT_BLOB_SERVICE_URL: &str = "http://localhost:50053"; and run blob locally with --http-port 50053 until I do the above

Revert the blob client port change

This revision is now accepted and ready to land.Aug 25 2023, 8:25 AM