Page MenuHomePhabricator
Differential D10608

[lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`
ClosedPublic
Actions

Authored by atul on Jan 11 2024, 9:03 AM.
Tags
None
Referenced Files
F3351284: D10608.diff
Sat, Nov 23, 12:47 AM
Unknown Object (File)
Wed, Nov 6, 12:53 PM
Unknown Object (File)
Tue, Nov 5, 4:07 PM
Unknown Object (File)
Tue, Nov 5, 3:52 PM
Unknown Object (File)
Tue, Nov 5, 1:23 PM
Unknown Object (File)
Tue, Nov 5, 1:13 PM
Unknown Object (File)
Tue, Nov 5, 8:48 AM
Unknown Object (File)
Thu, Oct 24, 6:28 AM
View All 87 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM4566286262c9: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`
Summary

Similar to D10606, but for registration.

Depends on D10606

Test Plan

N/A, trusting flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 11 2024, 9:03 AM
atul added a child revision: D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.Jan 11 2024, 9:19 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 9:20 AM
Harbormaster failed remote builds in B25702: Diff 35543!
atul updated this revision to Diff 35552.Jan 11 2024, 9:38 AM

rebase

atul published this revision for review.Jan 11 2024, 9:44 AM
atul planned changes to this revision.
ashoat accepted this revision.Jan 11 2024, 9:50 AM
ashoat added inline comments.
lib/types/account-types.js
71–77 ↗(On Diff #35552)

We should always convert types like this to read-only when we touch them. Can you try and see if it introduces any errors?

Harbormaster failed remote builds in B25711: Diff 35552!Jan 11 2024, 9:55 AM
atul updated this revision to Diff 35585.Jan 12 2024, 11:45 PM

address feedback (make readonly)

This revision is now accepted and ready to land.Jan 12 2024, 11:45 PM
atul updated this revision to Diff 35586.Jan 12 2024, 11:54 PM

remove extraneous change

Harbormaster failed remote builds in B25736: Diff 35585!Jan 13 2024, 12:02 AM
Harbormaster completed remote builds in B25737: Diff 35586.Jan 13 2024, 12:13 AM
atul updated this revision to Diff 35590.Jan 14 2024, 4:19 PM

land

This revision was landed with ongoing or failed builds.Jan 14 2024, 4:23 PM
Closed by commit rCOMM4566286262c9: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4566286262c9: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.
Harbormaster completed remote builds in B25740: Diff 35590.Jan 14 2024, 4:38 PM

Revision Contents
Changeset List

PathSize
lib/
types/
14 lines

Diff 35586

View Options

lib/types/account-types.js

Loading...