Page MenuHomePhabricator
Differential D10726

Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 1:43 PM.
Tags
None
Referenced Files
F3390518: D10726.id36075.diff
Sat, Nov 30, 12:16 AM
Unknown Object (File)
Tue, Nov 26, 5:36 PM
Unknown Object (File)
Tue, Nov 26, 5:35 PM
Unknown Object (File)
Tue, Nov 26, 3:26 PM
Unknown Object (File)
Thu, Nov 21, 11:59 AM
Unknown Object (File)
Mon, Nov 11, 1:38 PM
Unknown Object (File)
Thu, Nov 7, 4:23 AM
Unknown Object (File)
Oct 15 2024, 11:37 PM
View All 89 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |…
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Just like the rest of the stack we're going to expand RelativeMemberInfo and remove the Legacy* variant wherever possible.

Depends on D10725

Test Plan

flow, this was simple IDE "Inline alias..." refactor

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 18 2024, 1:43 PM
atul added a child revision: D10727: [lib] First pass at removing `LegacyRelativeMemberInfo` from `lib`.Jan 18 2024, 1:56 PM
Harbormaster completed remote builds in B25929: Diff 35851.Jan 18 2024, 2:02 PM
atul requested review of this revision.Jan 18 2024, 2:02 PM
ashoat accepted this revision.Jan 21 2024, 9:44 PM
ashoat added inline comments.
lib/selectors/thread-selectors.js
28

Please revert import ordering changes before landing

This revision is now accepted and ready to land.Jan 21 2024, 9:44 PM
atul updated this revision to Diff 36075.Jan 23 2024, 2:34 PM

rebase

Harbormaster completed remote builds in B26104: Diff 36075.Jan 23 2024, 3:13 PM
atul updated this revision to Diff 36290.Jan 29 2024, 9:34 AM

resolve merge conflicts

Harbormaster completed remote builds in B26262: Diff 36290.Jan 29 2024, 9:56 AM
atul updated this revision to Diff 36291.Jan 29 2024, 10:01 AM

re-introduce fixes

atul added a comment.Jan 29 2024, 10:03 AM

Double checked imports before landing.

Harbormaster completed remote builds in B26263: Diff 36291.Jan 29 2024, 10:21 AM
Closed by commit rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |… (authored by atul). · Explain WhyJan 29 2024, 11:54 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |….

Revision Contents
Changeset List

Diff 35851

View Options

lib/selectors/nav-selectors.js

Loading...
View Options

lib/selectors/thread-selectors.js

Loading...
View Options

lib/selectors/user-selectors.js

Loading...
View Options

lib/shared/markdown.js

Loading...
View Options

lib/shared/mention-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/role-utils.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/settings/thread-settings-member-tooltip-modal.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/roles/change-roles-screen.react.js

Loading...
View Options

web/input/input-state.js

Loading...
View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

Loading...
View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...
View Options

web/modals/threads/members/members-list.react.js

Loading...
View Options

web/modals/threads/members/members-modal.react.js

Loading...