Page MenuHomePhabricator
Differential D10733

[lib] Remove `LegacyRoleInfo` where possible in `lib`
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 11:46 PM
Unknown Object (File)
Mon, Apr 21, 11:46 PM
Unknown Object (File)
Sat, Apr 19, 6:14 PM
Unknown Object (File)
Fri, Apr 18, 10:04 PM
Unknown Object (File)
Fri, Apr 18, 10:04 PM
Unknown Object (File)
Fri, Apr 18, 10:04 PM
Unknown Object (File)
Thu, Apr 17, 2:18 PM
Unknown Object (File)
Thu, Apr 17, 11:54 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM025ebe207235: [lib] Remove `LegacyRoleInfo` where possible in `lib`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

There's not a whole lot we can remove here.

Depends on D10731

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
utils/
8 lines

Diff 35858

View Options

lib/utils/role-utils.js

Show First 20 Lines • Show All 1,529 Lines • ▼ Show 20 Lines throw std::system_error(
std::generic_category(), std::generic_category(),
"Multiple records found for the olm_persist_account table"); "Multiple records found for the olm_persist_account table");
} }
return (result.size() == 0) return (result.size() == 0)
? std::nullopt ? std::nullopt
: std::optional<std::string>(result[0].account_data); : std::optional<std::string>(result[0].account_data);
} }
void SQLiteQueryExecutor::storeOlmPersistData(crypto::Persist persist) const { void SQLiteQueryExecutor::storeOlmPersistAccount(
const std::string &accountData) const {
static std::string replaceOlmPersistAccountSQL = static std::string replaceOlmPersistAccountSQL =
"REPLACE INTO olm_persist_account (id, account_data) " "REPLACE INTO olm_persist_account (id, account_data) "
"VALUES (?, ?);"; "VALUES (?, ?);";
static std::string replaceOlmPersistSessionSQL =
"REPLACE INTO olm_persist_sessions (target_user_id, session_data) "
"VALUES (?, ?);";
OlmPersistAccount persistAccount = { OlmPersistAccount persistAccount = {ACCOUNT_ID, accountData};
ACCOUNT_ID, std::string(persist.account.begin(), persist.account.end())};
replaceEntity<OlmPersistAccount>( replaceEntity<OlmPersistAccount>(
SQLiteQueryExecutor::getConnection(), SQLiteQueryExecutor::getConnection(),
replaceOlmPersistAccountSQL, replaceOlmPersistAccountSQL,
persistAccount); persistAccount);
}
void SQLiteQueryExecutor::storeOlmPersistSession(
const OlmPersistSession &session) const {
static std::string replaceOlmPersistSessionSQL =
"REPLACE INTO olm_persist_sessions (target_user_id, session_data) "
"VALUES (?, ?);";
for (auto it = persist.sessions.begin(); it != persist.sessions.end(); it++) {
OlmPersistSession persistSession = {
it->first, std::string(it->second.begin(), it->second.end())};
replaceEntity<OlmPersistSession>( replaceEntity<OlmPersistSession>(
SQLiteQueryExecutor::getConnection(), SQLiteQueryExecutor::getConnection(),
replaceOlmPersistSessionSQL, replaceOlmPersistSessionSQL,
persistSession); session);
}
void SQLiteQueryExecutor::storeOlmPersistData(crypto::Persist persist) const {
std::string accountData =
std::string(persist.account.begin(), persist.account.end());
for (auto it = persist.sessions.begin(); it != persist.sessions.end(); it++) {
OlmPersistSession persistSession = {
it->first, std::string(it->second.begin(), it->second.end())};
this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const { void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token); this->setMetadata("notify_token", token);
} }
void SQLiteQueryExecutor::clearNotifyToken() const { void SQLiteQueryExecutor::clearNotifyToken() const {
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Lines for (const auto &thread : threads) {
webThreads.emplace_back(thread); webThreads.emplace_back(thread);
} }
return webThreads; return webThreads;
}; };
void SQLiteQueryExecutor::replaceThreadWeb(const WebThread &thread) const { void SQLiteQueryExecutor::replaceThreadWeb(const WebThread &thread) const {
this->replaceThread(thread.toThread()); this->replaceThread(thread.toThread());
}; };
std::vector<MessageWithMedias> SQLiteQueryExecutor::getAllMessagesWeb() const {
auto allMessages = this->getAllMessages();
std::vector<MessageWithMedias> allMessageWithMedias;
for (auto &messageWitMedia : allMessages) {
allMessageWithMedias.push_back(
{std::move(messageWitMedia.first), messageWitMedia.second});
}
return allMessageWithMedias;
}
void SQLiteQueryExecutor::replaceMessageWeb(const WebMessage &message) const {
this->replaceMessage(message.toMessage());
};
NullableString SQLiteQueryExecutor::getOlmPersistAccountDataWeb() const {
std::optional<std::string> accountData = this->getOlmPersistAccountData();
if (!accountData.has_value()) {
return NullableString();
}
return std::make_unique<std::string>(accountData.value());
}
#else #else
void SQLiteQueryExecutor::clearSensitiveData() { void SQLiteQueryExecutor::clearSensitiveData() {
SQLiteQueryExecutor::closeConnection(); SQLiteQueryExecutor::closeConnection();
if (file_exists(SQLiteQueryExecutor::sqliteFilePath) && if (file_exists(SQLiteQueryExecutor::sqliteFilePath) &&
std::remove(SQLiteQueryExecutor::sqliteFilePath.c_str())) { std::remove(SQLiteQueryExecutor::sqliteFilePath.c_str())) {
std::ostringstream errorStream; std::ostringstream errorStream;
errorStream << "Failed to delete database file. Details: " errorStream << "Failed to delete database file. Details: "
<< strerror(errno); << strerror(errno);
▲ Show 20 Lines • Show All 215 Lines • Show Last 20 Lines