Page MenuHomePhabricator
Differential D10789

[lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`
ClosedPublic
Actions

Authored by atul on Jan 22 2024, 10:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 3:40 AM
Unknown Object (File)
Mon, Apr 21, 11:47 PM
Unknown Object (File)
Mon, Apr 21, 11:47 PM
Unknown Object (File)
Mon, Apr 21, 11:47 PM
Unknown Object (File)
Mon, Apr 21, 11:47 PM
Unknown Object (File)
Mon, Apr 21, 11:46 PM
Unknown Object (File)
Mon, Apr 21, 11:46 PM
Unknown Object (File)
Mon, Apr 21, 11:46 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM9fba53f7a8a7: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedinfo-to-rawinfo

We won't really be able to remove usages of LegacyMemberInfo, but this will at least let us rename MinimallyEncodedMemberInfo to just MemberInfo.

Depends on D10734

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 22 2024, 10:15 AM
atul added a child revision: D10790: [lib] Remove single usage of `LegacyMemberInfo`.Jan 22 2024, 10:25 AM
Harbormaster completed remote builds in B26033: Diff 35969.Jan 22 2024, 10:33 AM
atul requested review of this revision.Jan 22 2024, 10:33 AM
ashoat accepted this revision.Jan 22 2024, 11:06 AM
This revision is now accepted and ready to land.Jan 22 2024, 11:06 AM
atul updated this revision to Diff 36083.Jan 23 2024, 2:38 PM

rebase

atul updated this revision to Diff 36084.Jan 23 2024, 2:38 PM

rebase

Harbormaster failed remote builds in B26112: Diff 36083!Jan 23 2024, 3:06 PM
Harbormaster failed remote builds in B26113: Diff 36084!Jan 23 2024, 3:08 PM
atul updated this revision to Diff 36106.Jan 24 2024, 8:11 PM

rebase

Harbormaster completed remote builds in B26132: Diff 36106.Jan 24 2024, 8:30 PM
atul updated this revision to Diff 36305.Jan 29 2024, 1:01 PM

rebase

Harbormaster completed remote builds in B26272: Diff 36305.Jan 29 2024, 1:22 PM
Closed by commit rCOMM9fba53f7a8a7: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo` (authored by atul). · Explain WhyJan 29 2024, 3:09 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9fba53f7a8a7: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.

Revision Contents
Changeset List

PathSize
lib/
shared/
20 lines
types/
3 lines

Diff 35969

View Options

lib/shared/thread-utils.js

Show All 16 Lines
import type { TagFarcasterChannelNavigationProp } from './tag-farcaster-channel-navigator.react.js'; import type { TagFarcasterChannelNavigationProp } from './tag-farcaster-channel-navigator.react.js';
import RegistrationButton from '../../account/registration/registration-button.react.js'; import RegistrationButton from '../../account/registration/registration-button.react.js';
import SWMansionIcon from '../../components/swmansion-icon.react.js'; import SWMansionIcon from '../../components/swmansion-icon.react.js';
import { type NavigationRoute } from '../../navigation/route-names.js'; import { type NavigationRoute } from '../../navigation/route-names.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { useStyles, useColors } from '../../themes/colors.js'; import { useStyles, useColors } from '../../themes/colors.js';
const tagFarcasterErrorMessages: { +[string]: string } = {
already_in_use: 'This Farcaster channel is already tagged to a community.',
ginsuAuthorUnsubmitted
Done
Inline Actions

This copy needs to be reviewed

ginsu: This copy needs to be reviewed
};
export type TagFarcasterChannelParams = { export type TagFarcasterChannelParams = {
+communityID: string, +communityID: string,
}; };
type Props = { type Props = {
+navigation: TagFarcasterChannelNavigationProp<'TagFarcasterChannel'>, +navigation: TagFarcasterChannelNavigationProp<'TagFarcasterChannel'>,
+route: NavigationRoute<'TagFarcasterChannel'>, +route: NavigationRoute<'TagFarcasterChannel'>,
}; };
Show All 12 Linesfunction TagFarcasterChannel(props: Props): React.Node {
const [selectedChannel, setSelectedChannel] = const [selectedChannel, setSelectedChannel] =
React.useState<?FarcasterChannel>(null); React.useState<?FarcasterChannel>(null);
const [channelOptions, setChannelOptions] = React.useState< const [channelOptions, setChannelOptions] = React.useState<
$ReadOnlyArray<FarcasterChannel>, $ReadOnlyArray<FarcasterChannel>,
>([]); >([]);
const [error, setError] = React.useState<?string>(null);
const neynarClientContext = React.useContext(NeynarClientContext); const neynarClientContext = React.useContext(NeynarClientContext);
invariant(neynarClientContext, 'NeynarClientContext is missing'); invariant(neynarClientContext, 'NeynarClientContext is missing');
const { client } = neynarClientContext; const { client } = neynarClientContext;
React.useEffect(() => { React.useEffect(() => {
void (async () => { void (async () => {
const channels = await client.fetchFollowedFarcasterChannels(fid); const channels = await client.fetchFollowedFarcasterChannels(fid);
Show All 19 Lines (selectedIndex: ?number) => {
} }
setSelectedChannel(channelOptions[selectedIndex]); setSelectedChannel(channelOptions[selectedIndex]);
}, },
[channelOptions], [channelOptions],
); );
const onPressSelectChannel = React.useCallback(() => { const onPressSelectChannel = React.useCallback(() => {
setError(null);
inkaUnsubmitted
Not Done
Inline Actions

Can we move this to onOptionSelected? If you disagree I won't insist, but it seems more natural to me that the error would disappear only once a different item is picked

inka: Can we move this to `onOptionSelected`? If you disagree I won't insist, but it seems more…
const channelNames = channelOptions.map(channel => channel.name); const channelNames = channelOptions.map(channel => channel.name);
const options = const options =
Platform.OS === 'ios' ? [...channelNames, 'Cancel'] : channelNames; Platform.OS === 'ios' ? [...channelNames, 'Cancel'] : channelNames;
const cancelButtonIndex = Platform.OS === 'ios' ? options.length - 1 : -1; const cancelButtonIndex = Platform.OS === 'ios' ? options.length - 1 : -1;
const containerStyle = { const containerStyle = {
Show All 28 Lines const createCreateOrUpdateActionPromise = React.useCallback(async () => {
} }
try { try {
return await createOrUpdateFarcasterChannelTag({ return await createOrUpdateFarcasterChannelTag({
commCommunityID: communityID, commCommunityID: communityID,
farcasterChannelID: selectedChannel.id, farcasterChannelID: selectedChannel.id,
}); });
} catch (e) { } catch (e) {
console.log('error', e); // TODO: Improve error handling setError(e.message);
throw e; throw e;
} }
}, [communityID, createOrUpdateFarcasterChannelTag, selectedChannel]); }, [communityID, createOrUpdateFarcasterChannelTag, selectedChannel]);
const onPressTag = React.useCallback(() => { const onPressTag = React.useCallback(() => {
void dispatchActionPromise( void dispatchActionPromise(
createOrUpdateFarcasterChannelTagActionTypes, createOrUpdateFarcasterChannelTagActionTypes,
createCreateOrUpdateActionPromise(), createCreateOrUpdateActionPromise(),
); );
}, [createCreateOrUpdateActionPromise, dispatchActionPromise]); }, [createCreateOrUpdateActionPromise, dispatchActionPromise]);
const channelSelectionStyles = React.useMemo( const channelSelectionStyles = React.useMemo(
() => [styles.sectionContainer, styles.touchableSectionContainer], () => [styles.sectionContainer, styles.touchableSectionContainer],
[styles.sectionContainer, styles.touchableSectionContainer], [styles.sectionContainer, styles.touchableSectionContainer],
); );
const errorMessage = React.useMemo(() => {
if (!error) {
return null;
}
return (
<Text style={styles.error}>
{tagFarcasterErrorMessages[error] ?? 'Unknown error.'}
ginsuAuthorUnsubmitted
Done
Inline Actions

Copy needs to be reviewed

ginsu: Copy needs to be reviewed
</Text>
);
}, [error, styles.error]);
const channelSelectionTextContent = selectedChannel?.name const channelSelectionTextContent = selectedChannel?.name
? selectedChannel.name ? selectedChannel.name
: 'No Farcaster channel tagged'; : 'No Farcaster channel tagged';
const buttonVariant = selectedChannel ? 'enabled' : 'disabled'; const buttonVariant = selectedChannel ? 'enabled' : 'disabled';
const tagFarcasterChannel = React.useMemo( const tagFarcasterChannel = React.useMemo(
() => ( () => (
Show All 10 Lines () => (
> >
<Text style={styles.sectionText}>{channelSelectionTextContent}</Text> <Text style={styles.sectionText}>{channelSelectionTextContent}</Text>
<SWMansionIcon <SWMansionIcon
name="edit-1" name="edit-1"
size={20} size={20}
color={colors.panelForegroundSecondaryLabel} color={colors.panelForegroundSecondaryLabel}
/> />
</TouchableOpacity> </TouchableOpacity>
<View style={styles.errorContainer}>{errorMessage}</View>
<RegistrationButton <RegistrationButton
onPress={onPressTag} onPress={onPressTag}
label="Tag channel" label="Tag channel"
variant={buttonVariant} variant={buttonVariant}
/> />
</View> </View>
), ),
[ [
styles.sectionContainer, styles.sectionContainer,
styles.sectionText, styles.sectionText,
styles.sectionHeaderText, styles.sectionHeaderText,
styles.errorContainer,
channelSelectionStyles, channelSelectionStyles,
onPressSelectChannel, onPressSelectChannel,
channelSelectionTextContent, channelSelectionTextContent,
colors.panelForegroundSecondaryLabel, colors.panelForegroundSecondaryLabel,
errorMessage,
onPressTag, onPressTag,
buttonVariant, buttonVariant,
], ],
); );
return tagFarcasterChannel; return tagFarcasterChannel;
} }
Show All 15 Lines sectionHeaderText: {
paddingHorizontal: 16, paddingHorizontal: 16,
paddingBottom: 4, paddingBottom: 4,
}, },
touchableSectionContainer: { touchableSectionContainer: {
flexDirection: 'row', flexDirection: 'row',
justifyContent: 'space-between', justifyContent: 'space-between',
alignItems: 'center', alignItems: 'center',
}, },
errorContainer: {
height: 18,
},
error: {
fontSize: 12,
fontWeight: '400',
lineHeight: 18,
textAlign: 'center',
color: 'redText',
},
}; };
export default TagFarcasterChannel; export default TagFarcasterChannel;
View Options

lib/types/thread-types.js

Show All 16 Lines
import type { TagFarcasterChannelNavigationProp } from './tag-farcaster-channel-navigator.react.js'; import type { TagFarcasterChannelNavigationProp } from './tag-farcaster-channel-navigator.react.js';
import RegistrationButton from '../../account/registration/registration-button.react.js'; import RegistrationButton from '../../account/registration/registration-button.react.js';
import SWMansionIcon from '../../components/swmansion-icon.react.js'; import SWMansionIcon from '../../components/swmansion-icon.react.js';
import { type NavigationRoute } from '../../navigation/route-names.js'; import { type NavigationRoute } from '../../navigation/route-names.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { useStyles, useColors } from '../../themes/colors.js'; import { useStyles, useColors } from '../../themes/colors.js';
const tagFarcasterErrorMessages: { +[string]: string } = {
already_in_use: 'This Farcaster channel is already tagged to a community.',
ginsuAuthorUnsubmitted
Done
Inline Actions

This copy needs to be reviewed

ginsu: This copy needs to be reviewed
};
export type TagFarcasterChannelParams = { export type TagFarcasterChannelParams = {
+communityID: string, +communityID: string,
}; };
type Props = { type Props = {
+navigation: TagFarcasterChannelNavigationProp<'TagFarcasterChannel'>, +navigation: TagFarcasterChannelNavigationProp<'TagFarcasterChannel'>,
+route: NavigationRoute<'TagFarcasterChannel'>, +route: NavigationRoute<'TagFarcasterChannel'>,
}; };
Show All 12 Linesfunction TagFarcasterChannel(props: Props): React.Node {
const [selectedChannel, setSelectedChannel] = const [selectedChannel, setSelectedChannel] =
React.useState<?FarcasterChannel>(null); React.useState<?FarcasterChannel>(null);
const [channelOptions, setChannelOptions] = React.useState< const [channelOptions, setChannelOptions] = React.useState<
$ReadOnlyArray<FarcasterChannel>, $ReadOnlyArray<FarcasterChannel>,
>([]); >([]);
const [error, setError] = React.useState<?string>(null);
const neynarClientContext = React.useContext(NeynarClientContext); const neynarClientContext = React.useContext(NeynarClientContext);
invariant(neynarClientContext, 'NeynarClientContext is missing'); invariant(neynarClientContext, 'NeynarClientContext is missing');
const { client } = neynarClientContext; const { client } = neynarClientContext;
React.useEffect(() => { React.useEffect(() => {
void (async () => { void (async () => {
const channels = await client.fetchFollowedFarcasterChannels(fid); const channels = await client.fetchFollowedFarcasterChannels(fid);
Show All 19 Lines (selectedIndex: ?number) => {
} }
setSelectedChannel(channelOptions[selectedIndex]); setSelectedChannel(channelOptions[selectedIndex]);
}, },
[channelOptions], [channelOptions],
); );
const onPressSelectChannel = React.useCallback(() => { const onPressSelectChannel = React.useCallback(() => {
setError(null);
inkaUnsubmitted
Not Done
Inline Actions

Can we move this to onOptionSelected? If you disagree I won't insist, but it seems more natural to me that the error would disappear only once a different item is picked

inka: Can we move this to `onOptionSelected`? If you disagree I won't insist, but it seems more…
const channelNames = channelOptions.map(channel => channel.name); const channelNames = channelOptions.map(channel => channel.name);
const options = const options =
Platform.OS === 'ios' ? [...channelNames, 'Cancel'] : channelNames; Platform.OS === 'ios' ? [...channelNames, 'Cancel'] : channelNames;
const cancelButtonIndex = Platform.OS === 'ios' ? options.length - 1 : -1; const cancelButtonIndex = Platform.OS === 'ios' ? options.length - 1 : -1;
const containerStyle = { const containerStyle = {
Show All 28 Lines const createCreateOrUpdateActionPromise = React.useCallback(async () => {
} }
try { try {
return await createOrUpdateFarcasterChannelTag({ return await createOrUpdateFarcasterChannelTag({
commCommunityID: communityID, commCommunityID: communityID,
farcasterChannelID: selectedChannel.id, farcasterChannelID: selectedChannel.id,
}); });
} catch (e) { } catch (e) {
console.log('error', e); // TODO: Improve error handling setError(e.message);
throw e; throw e;
} }
}, [communityID, createOrUpdateFarcasterChannelTag, selectedChannel]); }, [communityID, createOrUpdateFarcasterChannelTag, selectedChannel]);
const onPressTag = React.useCallback(() => { const onPressTag = React.useCallback(() => {
void dispatchActionPromise( void dispatchActionPromise(
createOrUpdateFarcasterChannelTagActionTypes, createOrUpdateFarcasterChannelTagActionTypes,
createCreateOrUpdateActionPromise(), createCreateOrUpdateActionPromise(),
); );
}, [createCreateOrUpdateActionPromise, dispatchActionPromise]); }, [createCreateOrUpdateActionPromise, dispatchActionPromise]);
const channelSelectionStyles = React.useMemo( const channelSelectionStyles = React.useMemo(
() => [styles.sectionContainer, styles.touchableSectionContainer], () => [styles.sectionContainer, styles.touchableSectionContainer],
[styles.sectionContainer, styles.touchableSectionContainer], [styles.sectionContainer, styles.touchableSectionContainer],
); );
const errorMessage = React.useMemo(() => {
if (!error) {
return null;
}
return (
<Text style={styles.error}>
{tagFarcasterErrorMessages[error] ?? 'Unknown error.'}
ginsuAuthorUnsubmitted
Done
Inline Actions

Copy needs to be reviewed

ginsu: Copy needs to be reviewed
</Text>
);
}, [error, styles.error]);
const channelSelectionTextContent = selectedChannel?.name const channelSelectionTextContent = selectedChannel?.name
? selectedChannel.name ? selectedChannel.name
: 'No Farcaster channel tagged'; : 'No Farcaster channel tagged';
const buttonVariant = selectedChannel ? 'enabled' : 'disabled'; const buttonVariant = selectedChannel ? 'enabled' : 'disabled';
const tagFarcasterChannel = React.useMemo( const tagFarcasterChannel = React.useMemo(
() => ( () => (
Show All 10 Lines () => (
> >
<Text style={styles.sectionText}>{channelSelectionTextContent}</Text> <Text style={styles.sectionText}>{channelSelectionTextContent}</Text>
<SWMansionIcon <SWMansionIcon
name="edit-1" name="edit-1"
size={20} size={20}
color={colors.panelForegroundSecondaryLabel} color={colors.panelForegroundSecondaryLabel}
/> />
</TouchableOpacity> </TouchableOpacity>
<View style={styles.errorContainer}>{errorMessage}</View>
<RegistrationButton <RegistrationButton
onPress={onPressTag} onPress={onPressTag}
label="Tag channel" label="Tag channel"
variant={buttonVariant} variant={buttonVariant}
/> />
</View> </View>
), ),
[ [
styles.sectionContainer, styles.sectionContainer,
styles.sectionText, styles.sectionText,
styles.sectionHeaderText, styles.sectionHeaderText,
styles.errorContainer,
channelSelectionStyles, channelSelectionStyles,
onPressSelectChannel, onPressSelectChannel,
channelSelectionTextContent, channelSelectionTextContent,
colors.panelForegroundSecondaryLabel, colors.panelForegroundSecondaryLabel,
errorMessage,
onPressTag, onPressTag,
buttonVariant, buttonVariant,
], ],
); );
return tagFarcasterChannel; return tagFarcasterChannel;
} }
Show All 15 Lines sectionHeaderText: {
paddingHorizontal: 16, paddingHorizontal: 16,
paddingBottom: 4, paddingBottom: 4,
}, },
touchableSectionContainer: { touchableSectionContainer: {
flexDirection: 'row', flexDirection: 'row',
justifyContent: 'space-between', justifyContent: 'space-between',
alignItems: 'center', alignItems: 'center',
}, },
errorContainer: {
height: 18,
},
error: {
fontSize: 12,
fontWeight: '400',
lineHeight: 18,
textAlign: 'center',
color: 'redText',
},
}; };
export default TagFarcasterChannel; export default TagFarcasterChannel;