[lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`
ClosedPublic
Actions

Authored by atul on Jan 15 2024, 1:33 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM91e6d77671c9: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`

Summary

As part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

We've now replaced all instances of the ThreadInfo alias so we can rip it out. In next diff we will rename MinimallyEncodedThreadInfo to ThreadInfo.

Depends on D10641

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 15 2024, 1:33 PM

atul added a child revision: D10643: Rename `MinimallyEncodedThreadInfo` to `ThreadInfo`.Jan 15 2024, 1:41 PM

Harbormaster completed remote builds in B25781: Diff 35644.Jan 15 2024, 1:52 PM

atul requested review of this revision.Jan 15 2024, 1:52 PM

ashoat accepted this revision.Jan 15 2024, 5:39 PM

This revision is now accepted and ready to land.Jan 15 2024, 5:39 PM

rebase

This revision was landed with ongoing or failed builds.Jan 22 2024, 12:36 PM

Closed by commit rCOMM91e6d77671c9: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM91e6d77671c9: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`.

Harbormaster completed remote builds in B26052: Diff 35995.Jan 22 2024, 12:45 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

thread-types.js

6 lines

Diff 35995

View Options

lib/types/thread-types.js

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines	function CommunityDrawer(): React.Node {
}, []);		}, []);

const communitiesComponents = drawerItemsData.map(item => (		const communitiesComponents = drawerItemsData.map(item => (
<CommunityDrawerItemCommunity		<CommunityDrawerItemCommunity
itemData={item}		itemData={item}
key={item.threadInfo.id}		key={item.threadInfo.id}
toggleExpanded={setOpenCommunityOrClose}		toggleExpanded={setOpenCommunityOrClose}
expanded={item.threadInfo.id === openCommunity}		expanded={item.threadInfo.id === openCommunity}
		paddingLeft={10}
/>		/>
));		));

return (		return (
<ThreadListProvider>		<ThreadListProvider>
<div className={css.container}>{communitiesComponents}</div>		<div className={css.container}>{communitiesComponents}</div>
</ThreadListProvider>		</ThreadListProvider>
);		);
}		}

export default CommunityDrawer;		export default CommunityDrawer;

[lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`ClosedPublicActions