Page MenuHomePhabricator
Differential D10646

[lib] Narrow `threadUIName` to `ThreadInfo`
ClosedPublic
Actions

Authored by atul on Jan 15 2024, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:47 AM
Unknown Object (File)
Tue, Apr 8, 8:35 PM
Unknown Object (File)
Sun, Mar 23, 9:34 PM
Unknown Object (File)
Sun, Mar 23, 9:34 PM
Unknown Object (File)
Sun, Mar 23, 9:33 PM
Unknown Object (File)
Sun, Mar 23, 9:33 PM
Unknown Object (File)
Mon, Mar 17, 12:42 PM
Unknown Object (File)
Feb 25 2025, 2:26 AM
View All 84 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM5f0b85664bf1: [lib] Narrow `threadUIName` to `ThreadInfo`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

I obviously don't want to make a separate diff for every function I modify in thread-utils, but figured it made sense to make this its own diff since there are corresponding changes to thread-settings-modal at callsite.

This also removes a bit of branching.

Depends on D10645

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
19 lines
web/
modals/
threads/
settings/
7 lines

Diff 36007

View Options

lib/shared/thread-utils.js

Show All 30 Lines
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
if (DISABLE_TAGGING_FARCASTER_CHANNEL) { if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error'); throw new ServerError('internal_error');
} }
const [serverCommunityInfos, blobDownload] = await Promise.all([ const [communityInfos, blobDownload] = await Promise.all([
fetchCommunityInfos(viewer), fetchCommunityInfos(viewer, [request.commCommunityID]),
getFarcasterChannelTagBlob(request.farcasterChannelID), getFarcasterChannelTagBlob(request.farcasterChannelID),
]); ]);
const communityInfo = serverCommunityInfos.find( if (communityInfos.length !== 1) {
community => community.id === request.commCommunityID,
);
if (!communityInfo) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Show All 30 Lines
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
if (DISABLE_TAGGING_FARCASTER_CHANNEL) { if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error'); throw new ServerError('internal_error');
} }
const [serverCommunityInfos, blobDownload] = await Promise.all([ const [communityInfos, blobDownload] = await Promise.all([
fetchCommunityInfos(viewer), fetchCommunityInfos(viewer, [request.commCommunityID]),
getFarcasterChannelTagBlob(request.farcasterChannelID), getFarcasterChannelTagBlob(request.farcasterChannelID),
]); ]);
const communityInfo = serverCommunityInfos.find( if (communityInfos.length !== 1) {
community => community.id === request.commCommunityID,
);
if (!communityInfo) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines