Page MenuHomePhabricator
Differential D10729

[lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 2:03 PM.
Tags
None
Referenced Files
F5358866: D10729.diff
Wed, Apr 9, 11:57 AM
Unknown Object (File)
Wed, Apr 9, 12:29 AM
Unknown Object (File)
Tue, Apr 8, 8:31 PM
Unknown Object (File)
Tue, Apr 8, 7:58 PM
Unknown Object (File)
Mar 7 2025, 11:34 AM
Unknown Object (File)
Feb 24 2025, 7:07 PM
Unknown Object (File)
Feb 21 2025, 8:06 PM
Unknown Object (File)
Feb 21 2025, 8:06 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM73d2fd7b4e3f: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase
Summary

Part of ENG-6366 : Rename MinimallyEncodedRawThreadInfo to RawThreadInfo

Depends on D10728

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 18 2024, 2:03 PM
atul added a child revision: D10730: Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo`.Jan 18 2024, 2:05 PM
Harbormaster completed remote builds in B25932: Diff 35854.Jan 18 2024, 2:22 PM
atul requested review of this revision.Jan 18 2024, 2:22 PM
ashoat accepted this revision.Jan 21 2024, 9:50 PM
This revision is now accepted and ready to land.Jan 21 2024, 9:50 PM
atul updated this revision to Diff 36078.Jan 23 2024, 2:36 PM

rebase

Harbormaster completed remote builds in B26107: Diff 36078.Jan 23 2024, 3:12 PM
atul updated this revision to Diff 36296.Jan 29 2024, 12:18 PM

rebase

atul added a comment.Jan 29 2024, 12:32 PM

Double checked for import issues before landing.

Harbormaster completed remote builds in B26267: Diff 36296.Jan 29 2024, 12:38 PM
Closed by commit rCOMM73d2fd7b4e3f: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase (authored by atul). · Explain WhyJan 29 2024, 12:44 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM73d2fd7b4e3f: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase.

Revision Contents
Changeset List

PathSize
lib/
selectors/
7 lines
shared/
11 lines
5 lines
types/
6 lines
utils/
6 lines

Diff 36078

View Options

lib/selectors/nav-selectors.js

Show All 30 Lines
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
if (DISABLE_TAGGING_FARCASTER_CHANNEL) { if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error'); throw new ServerError('internal_error');
} }
const [serverCommunityInfos, blobDownload] = await Promise.all([ const [communityInfos, blobDownload] = await Promise.all([
fetchCommunityInfos(viewer), fetchCommunityInfos(viewer, [request.commCommunityID]),
getFarcasterChannelTagBlob(request.farcasterChannelID), getFarcasterChannelTagBlob(request.farcasterChannelID),
]); ]);
const communityInfo = serverCommunityInfos.find( if (communityInfos.length !== 1) {
community => community.id === request.commCommunityID,
);
if (!communityInfo) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

lib/shared/mention-utils.js

Show All 30 Lines
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
if (DISABLE_TAGGING_FARCASTER_CHANNEL) { if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error'); throw new ServerError('internal_error');
} }
const [serverCommunityInfos, blobDownload] = await Promise.all([ const [communityInfos, blobDownload] = await Promise.all([
fetchCommunityInfos(viewer), fetchCommunityInfos(viewer, [request.commCommunityID]),
getFarcasterChannelTagBlob(request.farcasterChannelID), getFarcasterChannelTagBlob(request.farcasterChannelID),
]); ]);
const communityInfo = serverCommunityInfos.find( if (communityInfos.length !== 1) {
community => community.id === request.commCommunityID,
);
if (!communityInfo) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

Show All 30 Lines
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
if (DISABLE_TAGGING_FARCASTER_CHANNEL) { if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error'); throw new ServerError('internal_error');
} }
const [serverCommunityInfos, blobDownload] = await Promise.all([ const [communityInfos, blobDownload] = await Promise.all([
fetchCommunityInfos(viewer), fetchCommunityInfos(viewer, [request.commCommunityID]),
getFarcasterChannelTagBlob(request.farcasterChannelID), getFarcasterChannelTagBlob(request.farcasterChannelID),
]); ]);
const communityInfo = serverCommunityInfos.find( if (communityInfos.length !== 1) {
community => community.id === request.commCommunityID,
);
if (!communityInfo) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

Show All 30 Lines
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
if (DISABLE_TAGGING_FARCASTER_CHANNEL) { if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error'); throw new ServerError('internal_error');
} }
const [serverCommunityInfos, blobDownload] = await Promise.all([ const [communityInfos, blobDownload] = await Promise.all([
fetchCommunityInfos(viewer), fetchCommunityInfos(viewer, [request.commCommunityID]),
getFarcasterChannelTagBlob(request.farcasterChannelID), getFarcasterChannelTagBlob(request.farcasterChannelID),
]); ]);
const communityInfo = serverCommunityInfos.find( if (communityInfos.length !== 1) {
community => community.id === request.commCommunityID,
);
if (!communityInfo) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

lib/utils/role-utils.js

Loading...