Page MenuHomePhabricator
Differential D10810

Remove branching on `.minimallyEncoded` where no longer relevant
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 10:19 PM.
Tags
None
Referenced Files
F3374404: D10810.diff
Tue, Nov 26, 3:26 PM
Unknown Object (File)
Thu, Nov 7, 3:51 AM
Unknown Object (File)
Tue, Nov 5, 3:16 PM
Unknown Object (File)
Oct 25 2024, 9:45 PM
Unknown Object (File)
Oct 15 2024, 10:07 PM
Unknown Object (File)
Oct 15 2024, 10:07 PM
Unknown Object (File)
Oct 15 2024, 10:07 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
View All 64 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMec1571821829: Remove branching on `.minimallyEncoded` where no longer relevant
Summary

Remove branching on minimallyEncoded where no longer relevant.

Depends on D10807

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 24 2024, 10:19 PM
atul added a child revision: D10811: [web][native] Remove branching on `minimallyEncoded` in `redux-setup`.Jan 24 2024, 10:24 PM
Harbormaster completed remote builds in B26147: Diff 36123.Jan 24 2024, 10:38 PM
atul requested review of this revision.Jan 24 2024, 10:38 PM
tomek accepted this revision.Jan 25 2024, 2:56 AM
tomek added inline comments.
lib/shared/thread-utils.js
1380–1381

Just to make sure: can we assume that the defaultRole is always minimally-encoded?

1666–1668

The same here: can we assume the encoding?

This revision is now accepted and ready to land.Jan 25 2024, 2:56 AM
ashoat added a comment.Jan 25 2024, 8:27 AM

Can you remove the extra newlines before landing? I'm assuming they're not intentional

atul added a comment.Jan 25 2024, 8:35 AM
In D10810#311730, @ashoat wrote:

Can you remove the extra newlines before landing? I'm assuming they're not intentional

Yeah my bad, really need to figure out my editor config after the ESLint/Prettier/etc bump to avoid all the noise that’s getting added. I’ll just turn it all off for now.

atul updated this revision to Diff 36328.Jan 29 2024, 3:14 PM

rebase

Harbormaster completed remote builds in B26288: Diff 36328.Jan 29 2024, 3:35 PM
atul updated this revision to Diff 36333.Jan 29 2024, 4:25 PM

remove whitelines

atul added inline comments.Jan 29 2024, 4:27 PM
lib/shared/thread-utils.js
1380–1381

Yeah, all the fields within a MinimallyEncodedThreadInfo should definitely be minimally encoded.

Harbormaster completed remote builds in B26293: Diff 36333.Jan 29 2024, 4:45 PM
Closed by commit rCOMMec1571821829: Remove branching on `.minimallyEncoded` where no longer relevant (authored by atul). · Explain WhyJan 29 2024, 7:15 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMec1571821829: Remove branching on `.minimallyEncoded` where no longer relevant.

Revision Contents
Changeset List

PathSize
lib/
shared/
23 lines
utils/
7 lines
native/
input/
15 lines
web/
input/
16 lines

Diff 36123

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/utils/drawer-utils.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...