Page MenuHomePhabricator
Differential D10734

[lib] Rename `MinimallyEncodedRoleInfo` to `RoleInfo`
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Tue, Oct 15, 10:43 PM
Unknown Object (File)
Sep 20 2024, 3:38 AM
View All 88 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM096f98c62af9: [lib] Rename `MinimallyEncodedRoleInfo` to `RoleInfo`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Depends on D10733

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 18 2024, 2:17 PM
Harbormaster completed remote builds in B25937: Diff 35859.Jan 18 2024, 2:35 PM
atul requested review of this revision.Jan 18 2024, 2:35 PM
ginsu accepted this revision.Jan 19 2024, 8:34 AM

seems like a straightforward rename diff

This revision is now accepted and ready to land.Jan 19 2024, 8:34 AM
ashoat added inline comments.Jan 21 2024, 10:21 PM
lib/permissions/minimally-encoded-thread-permissions-validators.js
14–15 ↗(On Diff #35859)

Please revert import ordering changes before landing

atul added a child revision: D10789: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.Jan 22 2024, 10:15 AM
atul updated this revision to Diff 36082.Jan 23 2024, 2:37 PM

rebase

Harbormaster completed remote builds in B26111: Diff 36082.Jan 23 2024, 3:14 PM
atul updated this revision to Diff 36304.Jan 29 2024, 1:01 PM

rebase

Harbormaster completed remote builds in B26271: Diff 36304.Jan 29 2024, 1:20 PM
atul updated this revision to Diff 36312.Jan 29 2024, 2:07 PM

rebase: fix import

Harbormaster completed remote builds in B26279: Diff 36312.Jan 29 2024, 2:27 PM
Closed by commit rCOMM096f98c62af9: [lib] Rename `MinimallyEncodedRoleInfo` to `RoleInfo` (authored by atul). · Explain WhyJan 29 2024, 3:09 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM096f98c62af9: [lib] Rename `MinimallyEncodedRoleInfo` to `RoleInfo`.

Revision Contents
Changeset List

Diff 36304

View Options

lib/permissions/minimally-encoded-thread-permissions-validators.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...
View Options

lib/utils/role-utils.js

Loading...
View Options

lib/utils/thread-ops-utils.js

Loading...