Paths

Table of Contentst

Differential D10806

Get rid of `minimallyEncoded*` prefix for validators
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 9:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 30, 9:34 AM

	Unknown Object (File)
	Tue, Oct 15, 10:06 PM

	Unknown Object (File)
	Tue, Oct 15, 10:06 PM

	Unknown Object (File)
	Tue, Oct 15, 10:06 PM

	Unknown Object (File)
	Tue, Oct 15, 10:06 PM

	Unknown Object (File)
	Tue, Oct 15, 10:06 PM

	Unknown Object (File)
	Mon, Oct 7, 9:12 PM

	Unknown Object (File)
	Oct 5 2024, 4:34 AM

View All 51 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMac8cd76b19c2: Get rid of `minimallyEncoded*` prefix for validators

Summary

As of D10805, we no longer have any MinimallyEncoded* types. In some of the diffs that removed the prefix from the types I also removed the prefix from the corresponding validator name.. in some cases I didn't. This diff removes the prefix from validators where it remains.

Depends on D10805

Test Plan

flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 24 2024, 9:37 PM

atul added a child revision: D10807: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`.Jan 24 2024, 9:54 PM

Harbormaster completed remote builds in B26141: Diff 36117.Jan 24 2024, 9:57 PM

atul requested review of this revision.Jan 24 2024, 9:57 PM

tomek accepted this revision.Jan 25 2024, 2:48 AM

This revision is now accepted and ready to land.Jan 25 2024, 2:48 AM

rebase

Harbormaster completed remote builds in B26286: Diff 36326.Jan 29 2024, 3:33 PM

Closed by commit rCOMMac8cd76b19c2: Get rid of `minimallyEncoded*` prefix for validators (authored by atul). · Explain WhyJan 29 2024, 4:32 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMac8cd76b19c2: Get rid of `minimallyEncoded*` prefix for validators.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

redux-state-responders.js

4 lines

thread-responders.js

6 lines

user-responders.js

6 lines

shared/

state-sync/

threads-state-sync-spec.js

4 lines

lib/

permissions/

minimally-encoded-thread-permissions-validators.js

78 lines

minimally-encoded-thread-permissions.test.js

22 lines

shared/

updates/

join-thread-spec.js

4 lines

update-thread-spec.js

4 lines

types/

request-types.js

4 lines

socket-types.js

4 lines

utils/

thread-ops-utils.js

5 lines

web/

types/

4 lines

Diff 36326

keyserver/src/responders/redux-state-responders.js

Loading...

keyserver/src/responders/thread-responders.js

Loading...

keyserver/src/responders/user-responders.js

Loading...

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...

lib/permissions/minimally-encoded-thread-permissions-validators.js

Loading...

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...

lib/shared/updates/join-thread-spec.js

Loading...

lib/shared/updates/update-thread-spec.js

Loading...

lib/types/request-types.js

Loading...

lib/types/socket-types.js

Loading...

lib/utils/thread-ops-utils.js

Loading...

web/types/nav-types.js

Loading...