Remove branching on `.minimallyEncoded` where no longer relevant
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 10:19 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMec1571821829: Remove branching on `.minimallyEncoded` where no longer relevant

Summary

Remove branching on minimallyEncoded where no longer relevant.

Depends on D10807

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 24 2024, 10:19 PM

atul added a child revision: D10811: [web][native] Remove branching on `minimallyEncoded` in `redux-setup`.Jan 24 2024, 10:24 PM

Harbormaster completed remote builds in B26147: Diff 36123.Jan 24 2024, 10:38 PM

atul requested review of this revision.Jan 24 2024, 10:38 PM

tomek accepted this revision.Jan 25 2024, 2:56 AM

tomek added inline comments.

lib/shared/thread-utils.js
1380–1381 ↗	(On Diff #36123)	Just to make sure: can we assume that the `defaultRole` is always minimally-encoded?
1666–1668 ↗	(On Diff #36123)	The same here: can we assume the encoding?

This revision is now accepted and ready to land.Jan 25 2024, 2:56 AM

Can you remove the extra newlines before landing? I'm assuming they're not intentional

In D10810#311730, @ashoat wrote:

Can you remove the extra newlines before landing? I'm assuming they're not intentional

Yeah my bad, really need to figure out my editor config after the ESLint/Prettier/etc bump to avoid all the noise that’s getting added. I’ll just turn it all off for now.

rebase

Harbormaster completed remote builds in B26288: Diff 36328.Jan 29 2024, 3:35 PM

remove whitelines

atul added inline comments.Jan 29 2024, 4:27 PM