Move instruction to web setup
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jul 4 2023
Jul 3 2023
Jun 30 2023
not familiar with webpack copyplugin
LGTM, but don't have much of an opinion
Jun 29 2023
Nothing stands out to me that already hasn't been addressed.
Jun 27 2023
Yea, this looks right to me
Add aws credentials
Jun 26 2023
can we try to make this make_docker_image.sh script extensible to our other services?
seems to fine to me, but I will leave docker-specific items to bartek or varun
LGTM, would like for bartek to take a look.
Jun 20 2023
This isn't very concrete. Can you try to be more concrete?
Update aws credential location for docker compose
Can you be more concrete about the performance / efficiency benefits?
Tunnelbroker is at v0.5
Update docker-compose.yml, reduce file image size
On the one hand, it indeed creates a smaller context, but on the other hand, it lacks flexibility and is cumbersome to maintain. Imagine you add a file to the tunnelbroker directory but forget to update the script - it will work perfectly locally but won't be included in docker context -> prod container will fail. If somebody is unaware of this script, one will have a tough time debugging.
This work was later adapted by varun.
do you not need to call docker-compose build? i ask because for identity, normal docker build doesn't work i think (there is some context in the docker-compose.yml file that is required)
Address feedback
Address feedback
Jun 16 2023
Jun 14 2023
Jun 13 2023
LGTM, let atul have a look
Jun 12 2023
Rebase on master
Jun 11 2023
Jun 9 2023
Fix comment
Address feedback
Jun 8 2023
Jun 7 2023
LGTM, varun should review though
looks fine to me, but varun should also take a look