Page MenuHomePhorge
Feed Search

Jul 4 2023

jon updated the diff for D8326: [Docs] Mention Chrome needs to be restarted.

Move instruction to web setup

Jul 4 2023, 8:11 PM
jon added inline comments to D8366: [Keyserver/rust] Add device login and register.
Jul 4 2023, 8:08 PM

Jul 3 2023

jon requested review of D8405: [Keyserver] Attempt login to identity service.
Jul 3 2023, 2:29 PM

Jun 30 2023

jon accepted D8396: [blob-service] Require holder and blob_hash in 'remove' endpoint.
Jun 30 2023, 11:43 PM
jon added a comment to D8395: [web] add SQLite files to `.gitignore`.

LGTM

Jun 30 2023, 11:35 PM
jon resigned from D8393: [web] copy `.wasm` files using webpack.

not familiar with webpack copyplugin

Jun 30 2023, 11:34 PM
jon added a comment to D8392: [web] add managing WASM to yarn.

LGTM, but don't have much of an opinion

Jun 30 2023, 11:34 PM
jon requested changes to D8390: [shell] script to generate WASM database code.
Jun 30 2023, 11:33 PM
jon requested review of D8404: [Keyserver/rust] Remove legacy auth_token configuration.
Jun 30 2023, 11:19 PM
jon requested review of D8403: [Keyserver/rust] Enable logging of rust addon.
Jun 30 2023, 11:11 PM
jon requested review of D8402: [Identity] Fix opaque login.
Jun 30 2023, 11:07 PM
jon accepted D8388: [services] Match aws-sdk versions to Tunnelbroker.

LGTM

Jun 30 2023, 11:07 PM
jon accepted D8375: [nix] add emscripten dependency.
Jun 30 2023, 11:06 PM
jon requested review of D8401: [Identity] Allow for setting logging levels through env.
Jun 30 2023, 10:58 PM
jon requested review of D8400: [Keyserver] Apply DB Migrations.
Jun 30 2023, 10:53 PM
jon requested review of D8399: [Keyserver/rust] Ignore debug version of napi build.
Jun 30 2023, 10:43 PM
jon requested review of D8366: [Keyserver/rust] Add device login and register.
Jun 30 2023, 10:41 PM
jon requested review of D8365: [Keyserver] Remove legacy tunnelbroker types.
Jun 30 2023, 10:39 PM

Jun 29 2023

jon added a comment to D8367: [blob-service] Support HTTP Range header.

Nothing stands out to me that already hasn't been addressed.

Jun 29 2023, 2:22 PM
jon accepted D8361: [services] Delete unused COMM_TEST_SERVICES.
Jun 29 2023, 2:16 PM
jon accepted D8334: [chore] remove unused files and folders.
Jun 29 2023, 2:15 PM
jon accepted D8244: [services] Delete shared C++ lib.
Jun 29 2023, 2:15 PM

Jun 27 2023

jon accepted D8328: change AddReservedUsername to AddReservedUsernames.
Jun 27 2023, 4:15 PM
jon accepted D8336: [chore] clean up more services stuff.

Yea, this looks right to me

Jun 27 2023, 4:14 PM
jon accepted D8334: [chore] remove unused files and folders.
Jun 27 2023, 4:13 PM
jon closed D8230: [Tunnelbroker] Add docker image.
Jun 27 2023, 2:32 PM
jon committed rCOMMea5beb1448d8: [Tunnelbroker] Add docker image.
Jun 27 2023, 2:32 PM
jon requested review of D8326: [Docs] Mention Chrome needs to be restarted.
Jun 27 2023, 1:22 PM
jon updated the diff for D8312: [Docs] Document how to build and deploy tunnelbroker.

Add aws credentials

Jun 27 2023, 1:11 PM

Jun 26 2023

jon added inline comments to D8312: [Docs] Document how to build and deploy tunnelbroker.
Jun 26 2023, 10:42 PM
jon requested review of D8312: [Docs] Document how to build and deploy tunnelbroker.
Jun 26 2023, 1:39 PM
jon added a comment to D8230: [Tunnelbroker] Add docker image.

can we try to make this make_docker_image.sh script extensible to our other services?

Jun 26 2023, 1:34 PM
jon added a comment to D8305: [electron-update-server] Introduce new version.

seems to fine to me, but I will leave docker-specific items to bartek or varun

Jun 26 2023, 12:56 PM
jon added a comment to D8298: [identity] fix format of ed25519 public key and signature.

LGTM, would like for bartek to take a look.

Jun 26 2023, 12:55 PM
jon accepted D8299: [keyserver] improve error messages in rust-node-addon.
Jun 26 2023, 12:54 PM

Jun 20 2023

jon added inline comments to D8230: [Tunnelbroker] Add docker image.
Jun 20 2023, 5:40 PM
jon added a comment to D8230: [Tunnelbroker] Add docker image.

This isn't very concrete. Can you try to be more concrete?

Jun 20 2023, 5:36 PM
jon updated the diff for D8230: [Tunnelbroker] Add docker image.

Update aws credential location for docker compose

Jun 20 2023, 5:25 PM
jon added a comment to D8230: [Tunnelbroker] Add docker image.

Can you be more concrete about the performance / efficiency benefits?

Jun 20 2023, 5:13 PM
jon updated the diff for D8230: [Tunnelbroker] Add docker image.

Tunnelbroker is at v0.5

Jun 20 2023, 4:53 PM
jon updated the test plan for D8230: [Tunnelbroker] Add docker image.
Jun 20 2023, 4:52 PM
jon updated the diff for D8230: [Tunnelbroker] Add docker image.

Update docker-compose.yml, reduce file image size

Jun 20 2023, 4:51 PM
jon added a comment to D8230: [Tunnelbroker] Add docker image.

On the one hand, it indeed creates a smaller context, but on the other hand, it lacks flexibility and is cumbersome to maintain. Imagine you add a file to the tunnelbroker directory but forget to update the script - it will work perfectly locally but won't be included in docker context -> prod container will fail. If somebody is unaware of this script, one will have a tough time debugging.

Jun 20 2023, 4:51 PM
jon planned changes to D8052: [Keyserver] Use olm identity key for tunnelbroker connection.
Jun 20 2023, 2:15 PM
jon abandoned D7365: [Identity] Register user on native client.

This work was later adapted by varun.

Jun 20 2023, 2:05 PM
jon closed D8212: [Tunnelbroker] Remove C++ codebase.
Jun 20 2023, 2:04 PM
jon committed rCOMM301d5eb3ddc9: [Tunnelbroker] Remove C++ codebase.
Jun 20 2023, 2:04 PM
jon closed D8214: [Tunnelbroker] Make uri format more flexible.
Jun 20 2023, 3:13 AM
jon closed D8178: [Tunnelbroker] Use rabbitmq for message delivery.
Jun 20 2023, 3:13 AM
jon committed rCOMMb64d43975f40: [Tunnelbroker] Use rabbitmq for message delivery.
Jun 20 2023, 3:13 AM
jon committed rCOMM8cefffd48d71: [Tunnelbroker] Make uri format more flexible.
Jun 20 2023, 3:13 AM
jon closed D8177: [Tunnelbroker] Add amqp client crate, add minimal usage.
Jun 20 2023, 3:13 AM
jon committed rCOMM1d6de4d07114: [Tunnelbroker] Add amqp client crate, add minimal usage.
Jun 20 2023, 3:13 AM
jon requested review of D8230: [Tunnelbroker] Add docker image.

do you not need to call docker-compose build? i ask because for identity, normal docker build doesn't work i think (there is some context in the docker-compose.yml file that is required)

Jun 20 2023, 3:00 AM
jon updated the diff for D8178: [Tunnelbroker] Use rabbitmq for message delivery.

Address feedback

Jun 20 2023, 2:53 AM
jon updated the diff for D8178: [Tunnelbroker] Use rabbitmq for message delivery.

Address feedback

Jun 20 2023, 2:53 AM

Jun 16 2023

jon requested review of D8230: [Tunnelbroker] Add docker image.
Jun 16 2023, 3:13 AM

Jun 14 2023

jon requested review of D8214: [Tunnelbroker] Make uri format more flexible.
Jun 14 2023, 7:06 PM
jon requested review of D8212: [Tunnelbroker] Remove C++ codebase.
Jun 14 2023, 6:12 PM
jon accepted D8201: [keyserver] add addReservedUsername method to rust-node-addon.
Jun 14 2023, 2:40 PM
jon accepted D8202: [keyserver] add removeReservedUsername method to rust-node-addon.
Jun 14 2023, 2:40 PM
jon accepted D8206: [blob-service][HTTP] Get blobs by blob_hash.
Jun 14 2023, 2:38 PM
jon accepted D8205: [native] add missing files to iOS project.
Jun 14 2023, 2:37 PM
jon accepted D8203: [native] add missing entries in CMakeLists.
Jun 14 2023, 2:37 PM

Jun 13 2023

jon added inline comments to D8178: [Tunnelbroker] Use rabbitmq for message delivery.
Jun 13 2023, 5:57 PM
jon accepted D8188: [CI] Add blob unit tests GH action.

LGTM, let atul have a look

Jun 13 2023, 4:23 PM

Jun 12 2023

jon requested review of D8178: [Tunnelbroker] Use rabbitmq for message delivery.
Jun 12 2023, 10:11 PM
jon updated the diff for D8177: [Tunnelbroker] Add amqp client crate, add minimal usage.

Rebase on master

Jun 12 2023, 9:51 PM
jon accepted D8185: [docs] `Preferences` -> `Settings`.
Jun 12 2023, 9:03 PM
jon added inline comments to D8177: [Tunnelbroker] Add amqp client crate, add minimal usage.
Jun 12 2023, 5:07 PM
jon added inline comments to D8180: [blob-service] Validate holder and blob_hash inputs.
Jun 12 2023, 4:57 PM
jon accepted D8180: [blob-service] Validate holder and blob_hash inputs.
Jun 12 2023, 4:56 PM
jon accepted D8184: comm-dev.sh - remove unnecessary 'exit 1's.
Jun 12 2023, 4:50 PM
jon requested review of D8177: [Tunnelbroker] Add amqp client crate, add minimal usage.
Jun 12 2023, 2:43 PM
jon accepted D8179: [services-lib] Add is_valid_identifier function.
Jun 12 2023, 2:33 PM
jon requested changes to D8181: [shellcheck] Disable SC2317 in comm-dev.sh.
Jun 12 2023, 2:17 PM
jon accepted D8181: [shellcheck] Disable SC2317 in comm-dev.sh.
Jun 12 2023, 2:15 PM
jon closed D8127: [Identity] Implement upload one time keys endpoint.
Jun 12 2023, 3:04 AM
jon committed rCOMM1a8763370094: [Identity] Implement upload one time keys endpoint.
Jun 12 2023, 3:04 AM
jon closed D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Jun 12 2023, 3:04 AM
jon committed rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Jun 12 2023, 3:04 AM
jon closed D8094: [Identity] Refactor access token verification to be more usable.
Jun 12 2023, 3:04 AM
jon committed rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable.
Jun 12 2023, 3:03 AM

Jun 11 2023

jon added inline comments to D8127: [Identity] Implement upload one time keys endpoint.
Jun 11 2023, 9:49 PM

Jun 9 2023

jon accepted D8133: [identity] introduce RPC to update reserved usernames list.
Jun 9 2023, 6:01 PM
jon updated the diff for D8127: [Identity] Implement upload one time keys endpoint.

Fix comment

Jun 9 2023, 12:16 AM
jon updated the diff for D8094: [Identity] Refactor access token verification to be more usable.

Address feedback

Jun 9 2023, 12:14 AM

Jun 8 2023

jon requested review of D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Jun 8 2023, 11:57 PM

Jun 7 2023

jon added inline comments to D8134: [identity] implement addReservedUsername and removeReservedUsername RPCs.
Jun 7 2023, 10:12 PM
jon requested changes to D8133: [identity] introduce RPC to update reserved usernames list.
Jun 7 2023, 10:11 PM
jon added 1 blocking reviewer(s) for D8102: [blob-service] Use S3 errors in HTTP endpoints: varun.
Jun 7 2023, 10:06 PM
jon added a comment to D8102: [blob-service] Use S3 errors in HTTP endpoints.

LGTM, varun should review though

Jun 7 2023, 10:06 PM
jon added a comment to D8101: [blob-service] Use new error types in S3 functions.

looks fine to me, but varun should also take a look

Jun 7 2023, 9:51 PM
jon accepted D8100: [blob-service] Introduce S3-specific error types.
Jun 7 2023, 9:38 PM

Jun 6 2023

jon requested review of D8127: [Identity] Implement upload one time keys endpoint.
Jun 6 2023, 6:42 PM
jon requested review of D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Jun 6 2023, 5:56 PM
jon closed D8090: [Protos] Use outbound key bundle for keyserver information.
Jun 6 2023, 5:51 PM
jon committed rCOMM2e75c1a01b1b: [Protos] Use outbound key bundle for keyserver information.
Jun 6 2023, 5:51 PM
jon added 1 blocking reviewer(s) for D8094: [Identity] Refactor access token verification to be more usable: varun.
Jun 6 2023, 5:43 PM

Jun 5 2023

jon requested review of D8094: [Identity] Refactor access token verification to be more usable.
Jun 5 2023, 8:53 PM