Accepting although I wonder how hard it would be to put this into the keyserverStore (during backup creation we want to save all keyserver-related information and now instead of having it all in one places it's split between two fields in redux)

Potential ideas: (both of them are kinda iffy so up to you!)

• Merge datetime and timestamp parsing logic and use the attribute type (String/Number) to differentiate between the two
• We could do something like this for numbers (the dummy trait is required so there are conflicting implementations for FromStr types)

This will be very useful! I would prefer to have multiple packages in comm-services-lib/ (comm-services-lib/database-utils/, comm-services-lib/blob-client), but I don't really have strong argument against using features for this.

Fixed the readonly types. Amended the test plan for versions with and without conversion, and for rescinds where the notification was send to an older version/ from the older version of the keyserver.

Added util functions for encoding the version key. Amended the test plan.

Changed approach, more explanation in the updated description. Also updated the test plan.

Rebase

Checked the showCopyLink. showLearnSpelling is enabled by default but spellcheck in browser window is off by default so it doesn't show up.

Added showSaveImageAs and showSaveVideoAs.

Can this be done for all runners? Both windows and macos seem to have Yarn 1.22.19

Not a fan of using *, from what I understand that's basically any. I think we could use generics instead (we could also replace the * that existed before if we are changing the code anyway). There's also the option of using empty in places where we aren't using the generic fields, which would be "safer" because we wouldn't be able to use them, but this doesn't feel very clear.

We could probably simplify error handling by passing sqliteQueryExecutor as an argument (that's never null) to the operation handling functions. And move all "Database not initialized" error handling to the main funciton

Can we also check if the FILE_PATH contains no file (with module.FS.stat or sth)?

Looks good to me

LGTM!

Is there a chance that older web clients will still try to fetch this file?

How does this interact with migrations?

Nice!

Probably the "better solution" is the refactor @kamil is doing right now, but it makes sense to me to sequence it later, so we have something working on web already

Makes sense!

This one is really interesting! BindingType and TypeID both already exist in the emscripten codebase, but they are generic definitions (+ some specializations for specific types). We can add our own specializations for vectors, as this diff is doing. And c++ will use the "most specific" definition, so in this case for BindingType<vector<int>>, our definition will be more specific, than the generic BindingType<T> provided by emscripten.

comm-query-creator.js filename doesn't match the class inside

Personally I don't like the FS$ namespacing and don't think it's needed (it's namespaced to the the module/file anyway)

Can you amend the test plan with checking if the cookie was migrated correctly?

Seems like we are using keyserverPrefixID not as a prefix, but just as the server id. It would be more descriptive if it was named something like ashoatKeyserverID. Could make a task/ implement it quickly in a separate diff?

Also remove convertToNewIDSchema from genesis.js