thanks for clarifying!
Feed Search
Sep 13 2023
Sep 13 2023
ginsu added a comment to D9166: [native] Lift `renderSearch` to `ConnectedChatThreadList`.
I don't think it makes sense to block @atul's work here on transforming that to the new Reanimated API. We'll probably need to have the Reanimated conversion be a monthly goal for someone...
ginsu added a comment to D9166: [native] Lift `renderSearch` to `ConnectedChatThreadList`.
Also as I side note, I wonder if upgrading our animation code here to renanimated 2 or 3 api would improve performance. I know that renanimated 2-3 was built with functional components first in mind and IIRC the newer apis have a bunch of hooks to create animations in a more performant way
ginsu requested changes to D9166: [native] Lift `renderSearch` to `ConnectedChatThreadList`.
few questions inline
ginsu accepted D9164: [native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`.
please see inline comments before landing
please see inline comment before landing
ginsu accepted D9134: [native] Lift `searchUsers` and `onChangeSearchText` to `ConnectedChatThreadList`.
please make sure to check out inline comment before landing
Sep 12 2023
Sep 12 2023
ginsu updated the diff for D9119: [native] use stringForUserExplicit function to determine username text for profiles.
rebase before landing
ginsu updated the diff for D9094: [native] move BottomSheetModalProvider to inside NavigationContainer.
rebase before landing
ginsu updated the diff for D9101: [native] introduce user profile bottomsheet component.
rebase before landing
ginsu updated the diff for D9150: [native] memoize BottomSheetHandle.
spelling :/
ginsu updated the diff for D9150: [native] memoize BottomSheetHandle.
address @atul's feedback
ginsu accepted D9132: [native] Lift `openedSwipeableID`/`numItemsToDisplay` state to `ConnectedChatThreadList`.
thanks for fixing this!
ginsu requested review of D9150: [native] memoize BottomSheetHandle.
Sep 11 2023
Sep 11 2023
ginsu requested changes to D9132: [native] Lift `openedSwipeableID`/`numItemsToDisplay` state to `ConnectedChatThreadList`.
Might be overthinking this, so feel free to push back, but I think we can still use prevState with the useState hook
ginsu added a comment to D9130: [native] Lift `search[Status/Text]` state to `ConnectedChatThreadList`.
Thanks for breaking down this diff! It is super clear what the changes are!!
ginsu updated the diff for D9097: [web] fix message action tooltip placement for messages with inline engagement.
rebase before landing
ginsu requested review of D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Sep 9 2023
Sep 9 2023
Sep 8 2023
Sep 8 2023
ginsu requested changes to D9112: [lib/native] Remain consistent with url naming pattern.
actually after doing a quick global search it seems like the pattern is to have url be "URL" (it's not perfect throughout the codebase, but seems like the majority of cases go with all caps) . Could we make inviteLinkUrl => inviteLinkURL and qrCodeLinkUrl => qrCodeLinkURL
ginsu attached a referenced file: F747696: Screenshot 2023-09-08 at 9.23.05 AM.png.
ginsu added a comment to D9097: [web] fix message action tooltip placement for messages with inline engagement.
One question according to design:
Shouldn't the tooltip be aligned with the message?
cc. @ted(Sorry if this was discussed or if I am missing something, just sharing my thoughts from a "user perspective" as this tooltip placement is a bit confusing)
Sep 7 2023
Sep 7 2023
ginsu added a comment to D9094: [native] move BottomSheetModalProvider to inside NavigationContainer.
ginsu attached a referenced file: F746706: Screenshot 2023-09-06 at 3.48.35 PM.png.
ginsu updated the summary of D9094: [native] move BottomSheetModalProvider to inside NavigationContainer.
ginsu published D9101: [native] introduce user profile bottomsheet component for review.
Please wait for CI to pass before landing
ginsu requested review of D9098: [native] introduce onClosed callback prop to BottomSheet component.
Sep 6 2023
Sep 6 2023
ginsu updated the diff for D9088: [web] remove glow effect for the message action tooltip.
rebase before landing
ginsu added a comment to D9088: [web] remove glow effect for the message action tooltip.
Personally would prefer if in this same diff we opted for some sort of outline or shadow or anything to preserve the "depth" effect that the glow was supposed to provide
ginsu updated the diff for D9090: [native] make SingleLine the default export.
rebase before landing
ginsu updated the diff for D9013: [native] clean up profile UI for users with long usernames.
rebase before landing
ginsu updated the diff for D8981: [native] introduce bottom sheet backdrop component.
rebase before landing
ginsu updated subscribers of D8981: [native] introduce bottom sheet backdrop component.
ginsu requested review of D9094: [native] move BottomSheetModalProvider to inside NavigationContainer.
ginsu updated the diff for D8958: [native] introduce custom bottom sheet handle component.
rebase before landing
ginsu added inline comments to D8955: [native] introduce barebones bottom sheet component.
ginsu updated the diff for D8955: [native] introduce barebones bottom sheet component.
address comments / rebase before landing
Sep 5 2023
Sep 5 2023
ginsu requested review of D9090: [native] make SingleLine the default export.
ginsu updated the diff for D9013: [native] clean up profile UI for users with long usernames.
address comments
ginsu requested review of D9088: [web] remove glow effect for the message action tooltip.
ginsu requested review of D9087: [native] upgrade rn-emoji-keyboard to v1.5.1.
Aug 31 2023
Aug 31 2023
ginsu added inline comments to D9050: [native] Add some memoization to `Timestamp` component.
code looks good, @rohan when you have a chance could you take a look at my inline comment, thanks!
Aug 29 2023
Aug 29 2023
ginsu published D9013: [native] clean up profile UI for users with long usernames for review.
Aug 28 2023
Aug 28 2023
ginsu updated the summary of D8981: [native] introduce bottom sheet backdrop component.
ginsu attached a referenced file: F727731: Screen Recording 2023-08-28 at 12.34.55 PM.mov.
ginsu updated the summary of D8981: [native] introduce bottom sheet backdrop component.
ginsu requested review of D8981: [native] introduce bottom sheet backdrop component.
ginsu updated subscribers of D8955: [native] introduce barebones bottom sheet component.
ginsu updated the diff for D8935: [native] add BottomSheetModalProvider to the root component.
rebase before landing
ginsu updated the diff for D8915: [native] introduce copy username functionality to user profiles.
address comments / rebase before landing
ginsu updated the diff for D8914: [native] introduce user profile component.
rebase before landing
ginsu updated the diff for D8913: [native] introduce profileLarge avatar size.
rebase before landing
ginsu added a comment to D8913: [native] introduce profileLarge avatar size.
Created this linear task to track your feedback. Will try and get to it later this week