When do we want handleCurrentUserFID to run?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 27 2024
Making @ashoat a blocking reviewer since there is copy to review
I am not reviewing this because I assumed that you plan to introduce the changes we discussed. Is this incorrect?
Jun 25 2024
Use isLoggedInToKeyserver
Rebase
Jun 24 2024
"within" is not centered on web (vertically), can we fix this?
Can any other errors be thrown by signer.signMessage? Should we still throw them if so?
Why would a user be claiming a username from login screen? Isn't claiming username registration?
Should the secondary title say "Wallet Connected" on error?
Jun 21 2024
The space under the channel name looks awkward without the error to me (seems too big). Is there any way we can change this? I can see in invite links modal, that when an error appears we change the size of the modal to add the additional needed space. Could that work?
Check if empty
Don't remove commbot username. I didn't do it for all bots, because Object.entries(bots) is mixed, so there is no easy way to get the id. Also commbot is our only bot, so I don't think this is worth spending time on now
Jun 20 2024
I should exclude commbot, because it doesn't exist on the staging identity....
When relyingOnAuthoritativeKeyserver is true we want the client to update their avatar by calling the auth keyserver. This change makes the client disregard updateUserAvatarActionTypes if relyingOnAuthoritativeKeyserver is false, under the assumption that we would then call a different action. But actually we will probably want to reuse the action types and only change the promise used.
I think this diff should be dropped, because we will probably want to reuse the action types for peer-to-peer avatar updates, and for now we have a loose guarantee that this action is not called for a different keyserver, because the promise we use it with (updateUserAvatar) was not refactored for multiple keyservers. So it can only call the auth keyserver.
Rebase
Address review
Jun 7 2024
I will be absent next 1.5 weeks, so remove me from review if needed. I just need this FUTURE_CODE_VERSION/NEXT_CODE_VERSION flag change
Move dispatch
Check if response from auth keyserver exists
Jun 6 2024
Stop dispatching if array empty
Actually I should avoid dispatching the action if userIDs is empty. This results in a lot of unnecessary actions, mostly from PONG message
Address review