Page MenuHomePhabricator
Feed Advanced Search

Jun 27 2024

inka added a comment to D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

When do we want handleCurrentUserFID to run?

Jun 27 2024, 7:04 AM
inka accepted D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.
Jun 27 2024, 6:53 AM
inka added 1 blocking reviewer(s) for D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal: ashoat.

Making @ashoat a blocking reviewer since there is copy to review

Jun 27 2024, 6:50 AM
inka accepted D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.
Jun 27 2024, 6:49 AM
inka accepted D12566: [web] introduce CreateFarcasterChannelTagModal.
Jun 27 2024, 6:41 AM
inka added a comment to D12534: [lib/native/web] introduce RemoveTagButton.

I am not reviewing this because I assumed that you plan to introduce the changes we discussed. Is this incorrect?

Jun 27 2024, 6:32 AM
inka accepted D12565: [lib/native] lift tagFarcasterChannelErrorMessages into lib.
Jun 27 2024, 6:30 AM
inka accepted D12561: [web] Dropdown component improvements.
Jun 27 2024, 6:29 AM

Jun 25 2024

inka closed D12570: [lib] Wait for connection to auth ks before requesting user infos.
Jun 25 2024, 4:25 AM
inka committed rCOMM67772f9e9de4: [lib] Wait for connection to auth ks before requesting user infos (authored by inka).
[lib] Wait for connection to auth ks before requesting user infos
Jun 25 2024, 4:25 AM
inka updated the diff for D12570: [lib] Wait for connection to auth ks before requesting user infos.

Use isLoggedInToKeyserver

Jun 25 2024, 3:59 AM
inka requested review of D12570: [lib] Wait for connection to auth ks before requesting user infos.
Jun 25 2024, 2:47 AM
inka closed D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.
Jun 25 2024, 1:22 AM
inka closed D12513: [lib] Discard keyserver usernames for processServerRequestsActionType.
Jun 25 2024, 1:22 AM
inka committed rCOMMbad3d4b3542b: [lib] Discard keyserver usernames for updateUserAvatarActionTypes (authored by inka).
[lib] Discard keyserver usernames for updateUserAvatarActionTypes
Jun 25 2024, 1:22 AM
inka committed rCOMMc251b8874c5e: [lib] Discard keyserver usernames for processServerRequestsActionType (authored by inka).
[lib] Discard keyserver usernames for processServerRequestsActionType
Jun 25 2024, 1:22 AM
inka closed D12512: [lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType.
Jun 25 2024, 1:22 AM
inka committed rCOMMd47af6e867ce: [lib] Discard keyserver usernames for incremental state sync and… (authored by inka).
[lib] Discard keyserver usernames for incremental state sync and…
Jun 25 2024, 1:22 AM
inka closed D12510: [lib] Discard keyserver usernames for full state sync.
Jun 25 2024, 1:22 AM
inka closed D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.
Jun 25 2024, 1:22 AM
inka committed rCOMMd442aff70ff5: [lib] Discard keyserver usernames for keyserverAuthActionTypes (authored by inka).
[lib] Discard keyserver usernames for keyserverAuthActionTypes
Jun 25 2024, 1:22 AM
inka committed rCOMM96396357b076: [lib] Discard keyserver usernames for full state sync (authored by inka).
[lib] Discard keyserver usernames for full state sync
Jun 25 2024, 1:22 AM
inka closed D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.
Jun 25 2024, 1:22 AM
inka committed rCOMM3b6318c67a2c: [lib] Discard keyserver usernames for joinThreadActionTypes and… (authored by inka).
[lib] Discard keyserver usernames for joinThreadActionTypes and…
Jun 25 2024, 1:22 AM
inka closed D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes.
Jun 25 2024, 1:22 AM
inka closed D12331: [lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes.
Jun 25 2024, 1:22 AM
inka committed rCOMM47f523bb4362: [lib] Stop processing user infos from secondary keyservers on… (authored by inka).
[lib] Stop processing user infos from secondary keyservers on…
Jun 25 2024, 1:22 AM
inka committed rCOMMc4bb2947a732: [lib] Stop processing user infos from secondary keyservers on… (authored by inka).
[lib] Stop processing user infos from secondary keyservers on…
Jun 25 2024, 1:21 AM
inka closed D12329: [lib] Dispatch processNewUserIDsActionType.
Jun 25 2024, 1:21 AM
inka closed D12328: [lib] Avoid unnecessary state change in user reducer.
Jun 25 2024, 1:21 AM
inka committed rCOMMa5cc4bae8fe7: [lib] Dispatch processNewUserIDsActionType (authored by inka).
[lib] Dispatch processNewUserIDsActionType
Jun 25 2024, 1:21 AM
inka committed rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer (authored by inka).
[lib] Avoid unnecessary state change in user reducer
Jun 25 2024, 1:21 AM
inka closed D12319: [lib] Fetch user avatars for new user ids.
Jun 25 2024, 1:21 AM
inka committed rCOMMa5db4961c568: [lib] Fetch user avatars for new user ids (authored by inka).
[lib] Fetch user avatars for new user ids
Jun 25 2024, 1:21 AM
inka closed D12318: [lib] Don't remove avatar when fetching username.
Jun 25 2024, 1:21 AM
inka committed rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username (authored by inka).
[lib] Don't remove avatar when fetching username
Jun 25 2024, 1:21 AM
inka closed D12313: [keyserver][lib] Add ACKNOWLEDGE relationship action.
Jun 25 2024, 1:21 AM
inka committed rCOMM7828ee2c148f: [keyserver][lib] Add ACKNOWLEDGE relationship action (authored by inka).
[keyserver][lib] Add ACKNOWLEDGE relationship action
Jun 25 2024, 1:21 AM
inka updated the diff for D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.

Rebase

Jun 25 2024, 1:17 AM

Jun 24 2024

inka accepted D12553: [lib] flip usingCommServicesAccessToken to true.
Jun 24 2024, 7:55 AM
inka added a comment to D12422: [web][native] Display both thread and community names in the modal.

"within" is not centered on web (vertically), can we fix this?

Jun 24 2024, 1:05 AM
inka added a comment to D12549: [web] fix uncaught exception when user cancels SIWE.

Can any other errors be thrown by signer.signMessage? Should we still throw them if so?

Jun 24 2024, 12:39 AM
inka accepted D12548: [web] fix uncaught exception bug.
Jun 24 2024, 12:37 AM
inka added a comment to D12546: [web] inform password users that they need to log in from native to claim username.

Why would a user be claiming a username from login screen? Isn't claiming username registration?

Jun 24 2024, 12:32 AM
inka accepted D12545: [web] handle case where user needs to log in from native first.

Should the secondary title say "Wallet Connected" on error?

Jun 24 2024, 12:27 AM
inka accepted D12542: [native] fix error handling in TagFarcasterChannelByName.
Jun 24 2024, 12:13 AM
inka accepted D12541: [native] handle loading state in TagFarcasterChannelByName.
Jun 24 2024, 12:10 AM
inka accepted D12540: [native] fix indexing in tag channel button action sheet.
Jun 24 2024, 12:08 AM

Jun 21 2024

inka added inline comments to D12488: [lib] Introduce thickThreadTypes and ThickThreadType.
Jun 21 2024, 5:56 AM
inka added inline comments to D12513: [lib] Discard keyserver usernames for processServerRequestsActionType.
Jun 21 2024, 5:14 AM
inka added inline comments to D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.
Jun 21 2024, 5:08 AM
inka accepted D12538: [lib] introduce Tunnelbroker device token handler.
Jun 21 2024, 4:46 AM
inka accepted D12537: [lib] introduce setting Tunnelbroker device token action.
Jun 21 2024, 3:28 AM
inka accepted D12536: [lib][web][native] set local Tunnelbroker device token on client.
Jun 21 2024, 3:27 AM
inka accepted D12527: [lib][web][native] add Tunnelbroker device token to redux.
Jun 21 2024, 2:35 AM
inka accepted D12535: [lib/native] introduce useCreateFarcasterChannelTag.
Jun 21 2024, 1:17 AM
inka added a comment to D12534: [lib/native/web] introduce RemoveTagButton.

The space under the channel name looks awkward without the error to me (seems too big). Is there any way we can change this? I can see in invite links modal, that when an error appears we change the size of the modal to add the additional needed space. Could that work?

image.png (1×1 px, 110 KB)

image.png (1×1 px, 120 KB)

Jun 21 2024, 1:13 AM
inka accepted D12533: [native] fix button container height in RemoveTagButton.
Jun 21 2024, 12:57 AM
inka accepted D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Jun 21 2024, 12:56 AM
inka accepted D12530: [web] introduce TagFarcasterChannelModal.
Jun 21 2024, 12:42 AM
inka added inline comments to D12527: [lib][web][native] add Tunnelbroker device token to redux.
Jun 21 2024, 12:33 AM
inka updated the diff for D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.

Check if empty

Jun 21 2024, 12:15 AM
inka updated the diff for D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.

Don't remove commbot username. I didn't do it for all bots, because Object.entries(bots) is mixed, so there is no easy way to get the id. Also commbot is our only bot, so I don't think this is worth spending time on now

Jun 21 2024, 12:08 AM

Jun 20 2024

inka requested review of D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.
Jun 20 2024, 7:18 AM
inka requested review of D12513: [lib] Discard keyserver usernames for processServerRequestsActionType.
Jun 20 2024, 7:15 AM
inka planned changes to D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.

I should exclude commbot, because it doesn't exist on the staging identity....

Jun 20 2024, 6:55 AM
inka updated the test plan for D12512: [lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType.
Jun 20 2024, 6:43 AM
inka requested review of D12512: [lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType.
Jun 20 2024, 5:39 AM
inka requested review of D12510: [lib] Discard keyserver usernames for full state sync.
Jun 20 2024, 4:57 AM
inka added inline comments to D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.
Jun 20 2024, 4:41 AM
inka requested review of D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.
Jun 20 2024, 4:32 AM
inka abandoned D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.
Jun 20 2024, 3:00 AM
inka added a comment to D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.

When relyingOnAuthoritativeKeyserver is true we want the client to update their avatar by calling the auth keyserver. This change makes the client disregard updateUserAvatarActionTypes if relyingOnAuthoritativeKeyserver is false, under the assumption that we would then call a different action. But actually we will probably want to reuse the action types and only change the promise used.
I think this diff should be dropped, because we will probably want to reuse the action types for peer-to-peer avatar updates, and for now we have a loose guarantee that this action is not called for a different keyserver, because the promise we use it with (updateUserAvatar) was not refactored for multiple keyservers. So it can only call the auth keyserver.

Jun 20 2024, 2:59 AM
inka updated the diff for D12319: [lib] Fetch user avatars for new user ids.

Rebase

Jun 20 2024, 2:42 AM
inka updated the diff for D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.

Address review

Jun 20 2024, 2:41 AM
inka added inline comments to D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.
Jun 20 2024, 2:22 AM

Jun 7 2024

inka requested review of D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.
Jun 7 2024, 8:56 AM
inka added a comment to D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.

I will be absent next 1.5 weeks, so remove me from review if needed. I just need this FUTURE_CODE_VERSION/NEXT_CODE_VERSION flag change

Jun 7 2024, 8:51 AM
inka updated the diff for D12329: [lib] Dispatch processNewUserIDsActionType.

Move dispatch

Jun 7 2024, 7:23 AM
inka accepted D12330: [lib] update device list when updating `UserStore`.
Jun 7 2024, 7:08 AM
inka accepted D12326: [native] add back password input for account deletion.
Jun 7 2024, 6:36 AM
inka updated the test plan for D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes.
Jun 7 2024, 5:29 AM
inka updated the diff for D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes.

Check if response from auth keyserver exists

Jun 7 2024, 5:29 AM

Jun 6 2024

inka added inline comments to D12330: [lib] update device list when updating `UserStore`.
Jun 6 2024, 7:40 AM
inka requested review of D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.
Jun 6 2024, 7:04 AM
inka requested review of D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes.
Jun 6 2024, 6:59 AM
inka updated the diff for D12329: [lib] Dispatch processNewUserIDsActionType.

Stop dispatching if array empty

Jun 6 2024, 5:08 AM
inka planned changes to D12329: [lib] Dispatch processNewUserIDsActionType.

Actually I should avoid dispatching the action if userIDs is empty. This results in a lot of unnecessary actions, mostly from PONG message

Jun 6 2024, 5:03 AM
inka requested review of D12331: [lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes.
Jun 6 2024, 4:38 AM
inka updated the diff for D12318: [lib] Don't remove avatar when fetching username.

Address review

Jun 6 2024, 4:37 AM
inka requested review of D12329: [lib] Dispatch processNewUserIDsActionType.
Jun 6 2024, 4:05 AM
inka requested review of D12328: [lib] Avoid unnecessary state change in user reducer.
Jun 6 2024, 3:46 AM

Jun 5 2024

inka accepted D12320: [lib][web][native] Navigate to a thread after joining a community.
Jun 5 2024, 7:23 AM
inka accepted D12316: [web] Open a community when a user clicks an invite link and is already a member.
Jun 5 2024, 7:11 AM
inka accepted D12317: [native] Open a community when a user clicks an invite link and is already a member.
Jun 5 2024, 7:07 AM
inka requested review of D12318: [lib] Don't remove avatar when fetching username.
Jun 5 2024, 6:40 AM
inka requested review of D12319: [lib] Fetch user avatars for new user ids.
Jun 5 2024, 6:32 AM
inka added inline comments to D12313: [keyserver][lib] Add ACKNOWLEDGE relationship action.
Jun 5 2024, 5:14 AM
inka closed D12235: [lib][keyserver] Remove ADD_MEMBERS permission from community roots.
Jun 5 2024, 2:00 AM
inka committed rCOMMb65f4f3942e1: [lib][keyserver] Remove ADD_MEMBERS permission from community roots (authored by inka).
[lib][keyserver] Remove ADD_MEMBERS permission from community roots
Jun 5 2024, 2:00 AM