I'm worried about a scenario where the user doesn't open the app for a couple of days, and when they do all ops are suddenly deleted before they can be processed. Are we protected against that somehow?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 2 2024
Aug 2 2024
Aug 1 2024
Aug 1 2024
inka added a comment to D12952: [lib] Remove usernames sent by the keyserver and use reservedUserIdentifiers.
In D12952#366364, @bartek wrote:As far as I have context, this makes sense!
NOTE: We should add a note on Releases and Beyond that we need to deploy prod Identity before releasing native/web
In D12914#366270, @tomek wrote:What about +community?: ?string, field?
I got a little confused here. But I think that communities are always thin because they live on keyservers. So for a thick thread, it is not possible to assign a community. Am I right?
Jul 31 2024
Jul 31 2024
inka requested review of D12952: [lib] Remove usernames sent by the keyserver and use reservedUserIdentifiers.
Capitalize
inka added a reverting change for D12674: [lib] Fix missing usernames: D12952: [lib] Remove usernames sent by the keyserver and use reservedUserIdentifiers.
Yeah, I think that's the plan
inka added a comment to D12948: [lib] Add a function to DM operations spec checking if an operation can be applied.
Not sure if @ashoat's comment demands changes to this diff, please make sure to address it
inka accepted D12948: [lib] Add a function to DM operations spec checking if an operation can be applied.
This is great!
Can't we handle this in useProcessDMOperation just like canBeProcessed?
Should we set the unread status?
What about +community?: ?string, field?
Jul 30 2024
Jul 30 2024
Jul 26 2024
Jul 26 2024
inka committed rCOMM093bb2f18a91: [native][web] Fill target_message column for sidebar source (authored by inka).
[native][web] Fill target_message column for sidebar source
inka committed rCOMM86b47afb4189: [native][web] Fetch related messages for search (authored by inka).
[native][web] Fetch related messages for search
[native][web] Fix timestamp type in cpp
inka committed rCOMMb4354b47dc17: [keyserver][lib][web][native] use local search for thick threads (authored by inka).
[keyserver][lib][web][native] use local search for thick threads
Fix case
Change case
Rename
Add newline
Requesting review because I am not familiar with cpp and a lot of decisions had to be made
Use MessageType::SIDEBAR_SOURCE, update MessageType. Had to move MessageType to avoid importing folly on web
Jul 25 2024
Jul 25 2024
In D12866#364118, @tomek wrote:Have you tested it on both platforms?
Rebase
Rebase
Address review
inka added inline comments to D12865: [keyserver][lib][web][native] use local search for thick threads.
Address review
inka added inline comments to D12865: [keyserver][lib][web][native] use local search for thick threads.
Jul 24 2024
Jul 24 2024
One thing that doesnât work in thick threads is fetching next pages of results. This is because timestamps exceed cpp int, so SQLiteQueryExecutor::searchMessages doesnât bind them to sql query correctly. Fixing this is tracked in ENG-8893
inka added 1 blocking reviewer(s) for D12865: [keyserver][lib][web][native] use local search for thick threads: kamil.
Jul 23 2024
Jul 23 2024
inka committed rCOMM4d163ea41aef: [lib][web][native] Create message search store ops (authored by inka).
[lib][web][native] Create message search store ops
inka committed rCOMM42a24e328e36: [native] Add CommCoreModule code for inserting into the search table (authored by inka).
[native] Add CommCoreModule code for inserting into the search table
inka committed rCOMMed2425b8704c: [lib][web] Add worker logic for adding search messages (authored by inka).
[lib][web] Add worker logic for adding search messages
[native] Add message search store
Rebase
Move code to db-ops-reducer.js
[native] Add MessageSearchStoreOperations
inka committed rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table (authored by inka).
[web] Add bindings for inserting into the search table
inka committed rCOMM725ce1367367: [native] Add SQLiteQueryExecutor code for inserting into the search table (authored by inka).
[native] Add SQLiteQueryExecutor code for inserting into the search table
[native](web) Add message_search fts5 table
[native][web] Add fts5 extension to SQLite
inka updated the test plan for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.
Rebase
wasm
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.
wasm
wasm
Add CMake changes. Tested that android builds and no errors are thrown
Jul 22 2024
Jul 22 2024
Make read-only