Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me

Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.

Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me

address feedback

Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.

fix navigation param

address feedback

This is close, but requesting changes due to the volume of comments below

Passing back with some questions

Would appreciate @tomek's help in reviewing the QRAuthContext part... it's hard for me to track the whole flow and where connectingInProgress should be set

Thanks for explaining... not sure how I missed that. You'd think after 10 years of using Phabricator I'd be better at using it 😅

Thanks for sharing!

In D14098#393678, @ashoat wrote:

Thanks for finding this. Just wondering – did you find out because something was broken through testing, or because you observed that Flow was printing an error when the code looked right?

Rebase and change type from ?boolean to boolean | void

Rebase

Rebase

address feedback

rewrite as a functional component

Fix

Accepting so I don't block you, but please make sure you've considered whether there's any risks associated with this effect potentially being run on mount

Thank you for a detailed and thorough explanation!! You went really deep here, love it :)

Thanks for separating this out!

Similar feedback to prior diff: I think these getters can be replaced with the value itself. Feel free to do this all in one final diff in the stack if that's easier

Similar feedback to last diff: I think these getters can be replaced with the value itself

Great solution!

I didn't know about makeMutable! This is a much easier and cleaner solution than what I thought you'd have to do: introduce an OverlayNavigatorScreen component that wraps render() on line 577, and handles initializing the SharedValue.